Bug 58868 - TabFolder should support multi row style option
Summary: TabFolder should support multi row style option
Status: CLOSED WONTFIX
Alias: None
Product: Platform
Classification: Eclipse Project
Component: SWT (show other bugs)
Version: 3.0   Edit
Hardware: All All
: P3 enhancement with 15 votes (vote)
Target Milestone: ---   Edit
Assignee: Steve Northover CLA
QA Contact:
URL:
Whiteboard: stalebug
Keywords:
Depends on:
Blocks:
 
Reported: 2004-04-16 12:12 EDT by Morten Moeller CLA
Modified: 2019-09-24 13:50 EDT (History)
11 users (show)

See Also:


Attachments
SWT.MULTI without a manifest file (26.81 KB, image/x-png)
2004-04-16 17:17 EDT, Ed Burnette CLA
no flags Details
SWT.MULTI running *with* a manifest file (38.54 KB, image/x-png)
2004-04-16 17:18 EDT, Ed Burnette CLA
no flags Details
SWT.VERTICAL option without a manifest file (not included in the patch) (28.01 KB, image/x-png)
2004-04-16 17:20 EDT, Ed Burnette CLA
no flags Details
Patch to implement SWT.MULTI on Win32 (3.90 KB, patch)
2004-04-16 17:33 EDT, Ed Burnette CLA
no flags Details | Diff
Patch to the examples to use SWT.MULTI (2.90 KB, patch)
2004-04-16 17:34 EDT, Ed Burnette CLA
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Morten Moeller CLA 2004-04-16 12:12:45 EDT
I think SWT should allow for TabFolders to have multi-row tabs (if the OS 
supports it like at least Windows and Linux/GTK does). 
 
Suggest using SWT.MULTI to set the TCS_MULTILINE flag on the windows control 
at least.
Comment 1 Grant Gayed CLA 2004-04-16 12:19:47 EDT
api request, SN to consider
Comment 2 Ed Burnette CLA 2004-04-16 17:15:12 EDT
See also bug 28722.
Comment 3 Ed Burnette CLA 2004-04-16 17:17:11 EDT
Created attachment 9610 [details]
SWT.MULTI without a manifest file

I'm going to submit a patch to implement the SWT.MULTI flag for TabFolder.
Here's a screenshot of it in action.
Comment 4 Ed Burnette CLA 2004-04-16 17:18:52 EDT
Created attachment 9612 [details]
SWT.MULTI running *with* a manifest file

As seen on Windows XP SP1.
Comment 5 Ed Burnette CLA 2004-04-16 17:20:42 EDT
Created attachment 9613 [details]
SWT.VERTICAL option without a manifest file (not included in the patch)

I played around with adding a SWT.VERTICAL flag and it worked fine without the
manifest file (see the screenshot) but the text didn't appear when I did have a
manifest file. Therefore I pulled out that change. I guess CTabFolder will have
to do vertical tabs.
Comment 6 Morten Moeller CLA 2004-04-16 17:24:16 EDT
Nice work Ed. Will your patch include just Win32 support or Linux/GTK/OSX as  
well?  
 
Comment 7 Ed Burnette CLA 2004-04-16 17:30:30 EDT
Just Win32; somebody else will have to do the others. Until then it will have 
to just be taken as a hint and ignored on the other platforms.
Comment 8 Ed Burnette CLA 2004-04-16 17:33:18 EDT
Created attachment 9616 [details]
Patch to implement SWT.MULTI on Win32
Comment 9 Ed Burnette CLA 2004-04-16 17:34:53 EDT
Created attachment 9617 [details]
Patch to the examples to use SWT.MULTI

It should be verified that SWT.MULTI is ignored (if it's not implemented) on
platforms other than Win32 or this change to the examples might cause a problem
there.
Comment 10 Ed Burnette CLA 2004-04-20 22:09:20 EDT
Bug 52780 could use this.
Comment 11 Steve Northover CLA 2004-04-21 09:53:46 EDT
This is low priority and probably won't make it into 3.0.  There are "what 
about the other platforms?" issues as well as testing issues.  (ie. do 
computeSize(), getClientArea() etc. still work.  There are crazy work arounds 
in TabFolder on Windows for redrawing.  Are these broken?).

BTW: The SWT.MULTI kind of TabFolder is generally considered to be bad UI 
design.  The problem is that the tabs move and disorient the user.
Comment 12 Ed Burnette CLA 2004-04-21 10:34:35 EDT
I'd really like to see this make it in 3.0, for example the SWT Control 
example has 17 tabs and without this patch you often end up with those 
left/right arrows to scroll through them. I don't have a Mac or Linux box but 
if there's something else I can do on Windows, fixing bugs etc. let me know. 
The other platforms can just ignore the SWT.MULTI hint if they want and things 
should still work fine.

I don't necessarily like the way the tabs move around but I'm used to it by 
now from other apps like TextPad and many Windows XP dialogs, and it's better 
than the alternative. So that's not a good reason to hold off on it.

BTW, it seems to me that this has been requested a few times before but I 
can't find the other requests if they exist. Maybe I'm remembering passing 
references in other bugs that never got reported seperately.
Comment 13 Douglas Pollock CLA 2004-09-28 10:59:56 EDT
I would like to see this added for 3.1. 
 
Comment 14 Michael Bradburn CLA 2004-10-20 14:01:29 EDT
So would I.  To me, the tabs changing size and moving is a very small tradeoff
for being able to see tabs for all of the files that one has open.  It could
also be an optional setting so that those who like it the way it is now can keep
it that way.  When one is constantly switching files, the extra effort that one
exerts in selecting a file adds up.  One already has to select a file from a
long list of files in the package explorer and the way it it now makes one
select from another potentially long list (this one not being ordered in any
way) to switch to that file.
Comment 15 Douglas Pollock CLA 2004-10-20 14:13:09 EDT
From a discussion with Steve, I have opened Bug 76684 to cover the possibility 
of such an option on CTabFolder. 
Comment 16 Scott Stewart CLA 2004-12-07 14:29:11 EST
I find myself frequently editing 10-20 files with large file names, many of 
which begin with the same word.  With the icons, file-extensions, X (for 
closing), and the ellipsis, only the first 7 characters of the file name are 
displayed when 12 or more editors are open.  And this is with 1600 pixels to 
work with.

I work on a project with over 1000 files as I'm sure many eclipse users do.  
Not only does the large number of source files virtually guarantee I will be 
editing many at the same time, it also usually leads to larger file names (to 
avoid duplicates).  As far as I'm concerned, the tabs might as well not even 
exist when I have over 11 files open.

Switching editors by [some-action], [scan list of editors], [some-action] 
becomes quite a burden when switching editors multiple times per minute, which 
is done frequently in debugging.  Having the editors available already in 
plain view, prevents the first action, as well as limiting scan-time.

This is basically the only thing I don't like about Eclipse.  It *far* 
surpasses any other difficiency I ever notice.  There are so many comments 
about this problem.  Why not fix it sooner?  I know I obtained Eclipse for 
nothing, but I'd happily pay for this.
Comment 17 Mark A. Ziesemer CLA 2005-10-28 10:23:49 EDT
I'm in the same boat as Scott regarding his comment #16 and frequently editing 
many files.  Any chance of hitting this in 3.2, or at least a commitment to the 
next release if time no longer permits?  There are currently 17 votes between 
here and bug 28722, and Mr. Burnette has already contributed a good amount of 
work to this.  I'd rather run this feature officially than using a patched 
version of Eclipse.  Thanks!
Comment 18 Douglas Pollock CLA 2005-10-28 11:03:01 EDT
As a note, the editors in Eclipse use CTabFolder, not TabFolder.  As a result, 
anyone wanting multiple rows of editor tabs, you probably want to vote on Bug 
58945. 
 
Comment 19 Lars Vogel CLA 2019-09-24 13:50:02 EDT
This bug hasn't had any activity in quite some time. Maybe the problem got resolved, was a duplicate of something else, or became less pressing for some reason - or maybe it's still relevant but just hasn't been looked at yet.

If you have further information on the current state of the bug, please add it. The information can be, for example, that the problem still occurs, that you still want the feature, that more information is needed, or that the bug is (for whatever reason) no longer relevant.