Bug 58400 - [Repo View] Keyboard navigation in CVS Repo view is slow when Properties view open
Summary: [Repo View] Keyboard navigation in CVS Repo view is slow when Properties view...
Status: ASSIGNED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: CVS (show other bugs)
Version: 3.0   Edit
Hardware: PC Windows 2000
: P5 normal (vote)
Target Milestone: ---   Edit
Assignee: platform-cvs-inbox CLA
QA Contact:
URL:
Whiteboard:
Keywords: helpwanted, performance
Depends on:
Blocks:
 
Reported: 2004-04-13 21:39 EDT by Nick Edgar CLA
Modified: 2019-09-06 15:30 EDT (History)
2 users (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Nick Edgar CLA 2004-04-13 21:39:20 EDT
build I20040407

- with Properties view open in CVS perspective, use the arrow keys to select
different files in the repo view
- it feels very sluggish
- profiling shows that most of the time is spent in
CVSRemoteFilePropertySource.getPropertyValue(Object)

Not sure if much can be done in the repo view to address this.

It seems like the real problem is that the Properties view updates itself in a
selectionChanged event rather than a postSelectionChanged, or having its own
periodic update, and run this in a job.

Moving to CVS first for comment though.
Comment 1 Nick Edgar CLA 2004-04-13 21:47:11 EDT
Note: the slowness occurs even if the Properties view is open only in another
perspective in the same window.  It might help for the Properties view to only
update itself when visible (see IWorkbenchPage.isPartVisible and IPartListener2).
Comment 2 Jean-Michel Lemieux CLA 2004-04-14 08:42:55 EDT
This is because we are fetching the properties from the server. We could do this
in a background job. But not a priority for 3.0.
Comment 3 Tod Creasey CLA 2005-03-07 11:57:21 EST
Adding my name to the cc list as we are now tracking performance issues more
closely. Please remove the performance keyword if this is not a performance bug.
Comment 4 Mike Wilson CLA 2005-04-22 09:57:58 EDT
Not sure that this could be done this late in the cycle, but you need to update asynchronously. Suggest 
checking out the work the debug team did around updating the variables view.
Comment 5 Michael Valenta CLA 2005-04-25 09:30:48 EDT
Yes, we should be populating the Properties view in the background like we do 
with the Resource History view. However, we have not been focusing much effort 
on the Repositories view but have instead concentrated our effort on 
supporting day-to-day workflows that do not require the use of the 
Repositories view. The reason for this is that there are several major 
usability issues with the Repositories view that need to be addressed and we 
do not have the cycles to address them at this time.
Comment 6 Eclipse Webmaster CLA 2019-09-06 15:30:57 EDT
This bug hasn't had any activity in quite some time. Maybe the problem got resolved, was a duplicate of something else, or became less pressing for some reason - or maybe it's still relevant but just hasn't been looked at yet.

If you have further information on the current state of the bug, please add it. The information can be, for example, that the problem still occurs, that you still want the feature, that more information is needed, or that the bug is (for whatever reason) no longer relevant.