Community
Participate
Working Groups
I20040407 Opening external files fails in cases where there's an non-text or non-Java editor linked to it. Example: open an external build.xml or plugin.xml file
Please add to your use cases that Open External fails with all third-party plugins, as well. This problem is not resolved by "fixing" all the plugins that ship with Eclipse. Note that many third-party plugins supply their own DocumentProviders. Requiring a DocumentProvider that is incompatible with Eclipse resources may be necessary to allow such files to be opened independent of IResource, but it is not a good solution for plugins to Eclipse (the IDE).
In I20040514, the open not only fails, it fails silently, i.e., no dialog, no .log message.
WRT last comment, I am seeing plenty of error reporting in the runtime-workspace.
Removing target milestone, no further action for 3.0.
*** Bug 60012 has been marked as a duplicate of this bug. ***
*** Bug 70347 has been marked as a duplicate of this bug. ***
Created attachment 13555 [details] proposed patch This patch changes the generated Java source, so that future plugin developers won't encounter this bug. I looked into making a patch that would enable previously generated plugin's to work, but it looked like too much of a hack. Granted calling an internal class like this patch does is not good either.
The bug is about general problems with Open External File... and not specific to PDE UI against which your patch is.
My mistake, but it still seems like a useful patch for the PDE UI.
I did not comment on that ;-) File a new bug with the patch against PDE UI.
*** Bug 74026 has been marked as a duplicate of this bug. ***
see also bug 74194
Can someone fix this please. It halts all development. I cannot get this IDE to operate anything between 3.0.1 and beyond
My concern was probably closer to bug 70347 but it was marked as duplicate, so im posting here. I am having trouble as well. What am I supposed to do? The class org.eclipse.ui.internal.editors.text.JavaFileEditorInput is not accessible by me, but its being passed into my Editor. I can't do anything with this! Plus, I tried to see if it would give me a File throught the iadaptable interface, but no such luck. What am I supposed to do with this JavaFileEditorInput???
>What am I supposed to do with this JavaFileEditorInput??? see ILocationProvider.getPath(Object)
>see ILocationProvider.getPath(Object) I could say the exact same thing about that interface. Though I can import it, I certainly have no instances of it, nor do I know any way to get any instances of it. All Eclipse passes is 'IEditorInput'. I just don't understand. Eclipse has no problem opening a file and calling my plugin based on the file extension. In-workbench and out-of-workbench files are both opened and passed to my plugin's Editor of that filetype. But while the in-workbench ones are properly put into IFileEditorInputs, external files end up in some unaccessible instance of JavaFileEditorInput. So all I see is IEditorInput which has no useable methods, and all I can do is guess about what it can be adapted to. (again because I have no access to JavaFileEditorInput, nor any documentation) It just don't make sense. One should pass IFile, the other should pass File. Is there some part of the architecture that I missed? some extension perhaps?
OK, after finding the JavaFileEditorInput in CVS, I was able to figure out the workaround you were implying with ILocationProvider.getPath(Object) Its working, though after reading bug 74263, I understand this won't work cleanly. But its good enough to keep me going, thanks!
see also bug 74194.
This now works for editors that support IPathEditorInput and problems will no longer just be logged but the user will get feedback. Tested with several editors like PDE, Ant, embedded MS Word and external application.
start verifying
Test opening an external plugin.xml file and it correctly opened the plugin manifest editor.
