Bug 579475 - Remove dead logic from CSSPropertyBackgroundSWTHandler / AbstractCSSPropertyBackgroundHandler
Summary: Remove dead logic from CSSPropertyBackgroundSWTHandler / AbstractCSSPropertyB...
Status: RESOLVED FIXED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 4.22   Edit
Hardware: PC Linux
: P3 normal (vote)
Target Milestone: 4.24 M1   Edit
Assignee: Lars Vogel CLA
QA Contact:
URL:
Whiteboard:
Keywords:
: 534763 (view as bug list)
Depends on:
Blocks:
 
Reported: 2022-03-29 08:42 EDT by Lars Vogel CLA
Modified: 2022-08-16 05:17 EDT (History)
2 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Lars Vogel CLA 2022-03-29 08:42:47 EDT 
I'm currently looking into Bug 577463 and Bug 577493. CSSPropertyBackgroundSWTHandler / AbstractCSSPropertyBackgroundHandler contains some dummy / generated code without any logic which makes it harder to follow the execution path. This code is ancient and unnecessary so it should be removed.
Comment 1 Lars Vogel CLA 2022-03-29 08:43:26 EDT 
*** Bug 534763 has been marked as a duplicate of this bug. ***
Comment 2 Eclipse Genie CLA 2022-03-29 09:00:15 EDT 
New Gerrit change created: https://git.eclipse.org/r/c/platform/eclipse.platform.ui/+/192313
Comment 3 Eclipse Genie CLA 2022-03-29 10:14:29 EDT 
New Gerrit change created: https://git.eclipse.org/r/c/platform/eclipse.platform.ui/+/192315
Comment 6 Edit Mihancea CLA 2022-08-05 05:52:20 EDT 
Unfortunately this causes Bug 580520 on the NatTable, does it need a new release or INSTANCE should not have been removed?
Comment 7 Lars Vogel CLA 2022-08-16 05:17:30 EDT 
(In reply to Edit Mihancea from comment #6)
> Unfortunately this causes Bug 580520 on the NatTable, does it need a new
> release or INSTANCE should not have been removed?

AFAIK Nattable is putting out a new release. See https://github.com/eclipse-platform/eclipse.platform.ui/commit/001c32feb145039aea0b90c49496a5e5ab78e373#commitcomment-80720483