Comment 1 Dani Megert 2004-04-08 12:59:05 EDT

There are two task icons in eclipse.ide:

/icons/full/eview16/tasks_tsk.gif
/icons/full/obj16/taskmrk_tsk.gif

We correctly use IDE.SharedImages.IMG_OBJS_TASK_TSK which is
/icons/full/obj16/taskmrk_tsk.gif which is too wide.

The second bug is that in org.eclipse.ui.ide's plugin.xml the view image is
specified in the task's marker image provider:

  <extension
         point="org.eclipse.ui.ide.markerImageProviders">
      <imageprovider
            markertype="org.eclipse.core.resources.taskmarker"
            icon="icons/full/eview16/tasks_tsk.gif"
            id="org.eclipse.ui.taskMarkerProvider">
      </imageprovider>

Comment 2 Dani Megert 2004-04-16 02:21:26 EDT

*** Bug 58742 has been marked as a duplicate of this bug. ***

Comment 3 Dani Megert 2004-06-03 08:53:52 EDT

*** Bug 65109 has been marked as a duplicate of this bug. ***

Comment 4 Erich Gamma 2004-06-03 08:57:43 EDT

moving back to inbox

Comment 5 Andrée Proulx 2004-06-16 13:03:57 EDT

These two graphics are exactly the same in eclipse.ide:
/icons/full/eview16/tasks_tsk.gif
/icons/full/obj16/taskmrk_tsk.gif

To fit in the margin, a narrower graphic will be needed.
12x16 could work.

Comment 6 Andrée Proulx 2004-06-16 13:04:30 EDT

Created attachment 12290 [details]
task for editor margin

Comment 7 Kevin Haaland 2004-06-16 19:00:10 EDT

+1

Comment 8 Andrew Eidsness 2004-06-16 19:00:40 EDT

Tod and I reviewed and submitted a fix for this.

Comment 9 Tod Creasey 2004-06-16 19:01:22 EDT

New icons released by AE, reviewed by TC for build 20040616-2000

Comment 10 Andrew Eidsness 2004-06-16 19:44:53 EDT

Just to clarify comment #5.  The images in those two directories were the same 
but were used for different reasons.  The image in obj16 is used for the ruler 
in the margin (the subject of this bug) but the one in eview16 is used as the 
title image in the Tasks view tab.

The current change replaced both images, but I'm starting to wonder if only 
obj16 should have been updated.

Comment 11 Andrew Eidsness 2004-06-16 19:56:55 EDT

Tod and I have rolled back the change to eview16/tasks_tsk.gif which seems to be 
the right solution.  The images are now as:

/icons/full/eview16/tasks_tsk.gif : original, 16x16 image
/icons/full/obj16/taskmrk_tsk.gif : image in comment 6, 12x16 image

Comment 12 Andrée Proulx 2004-06-16 21:47:08 EDT

Would it be possible to use a 16x16 icon for the margin? I mean keep the 
current more compact concept but provide a cut at 16x16. Then it would be a 
question of aligning the icon properly in the margin. It seems this is what 
use to be done, but the icon was using too much real estate within the 16x16, 
and was clipped.

The reason I am asking to return to a 16x16, is really my bad. I should not 
introduce random size icons in the ui. Because icons are too pervasive and 
someone will eventualy grab this 12x16 and stretch it to 16x16. 

Just my luck, this person may not notice the icon is distorted. I am trying to 
avoid future blooper.

Find included the same small concept in a 16x16 cut.

Comment 13 Andrée Proulx 2004-06-16 21:47:55 EDT

Created attachment 12353 [details]
task for editor margin in 16x16

Comment 14 Andrew Eidsness 2004-06-17 10:59:18 EDT

I've verified that 200406170800 has the narrow task icon.

I'll look into putting this newer 16x16 icon back in.  Andrée, where is the 
transparency in this image?  All on the right or divided along each edge?

Comment 15 Andrew Eidsness 2004-06-17 11:09:59 EDT

I've tested the image from comment 13 and it looks good.

Comment 16 Andrée Proulx 2004-06-17 11:15:45 EDT

great thx. fyi, the image is centered in the real estate.

Comment 17 Andrew Eidsness 2004-06-17 11:29:19 EDT

Reviewed by tod, submitted to HEAD.

Comment 18 Debbie Wilson 2004-06-17 15:53:37 EDT

Verified in I20040617 (1217).