Community
Participate
Working Groups
split of from bug 578578: The existing interrupt() is not hard enough - it does only stop the autobuild loop but let the builder finish it's job - which can be a long time for big projects. The java build for example only looks at the IProgressMonitor in BuildNotifier.checkCancelWithinCompiler() The xtext builder instead looks at isInterrupted in XtextBuilder.shouldCancelBuild() We should either improve java builder to listen for interrupted or simply call cancel on the autobuildjob.
New Gerrit change created: https://git.eclipse.org/r/c/platform/eclipse.platform.resources/+/190567
Gerrit change https://git.eclipse.org/r/c/platform/eclipse.platform.resources/+/190567 was merged to [master]. Commit: http://git.eclipse.org/c/platform/eclipse.platform.resources.git/commit/?id=e6cf8197dad20aab0a714e9b91e6f1b1ff885c81
cancels the autobuild on interrupt
*I think it would be better to revert this change* Today i tested https://bugs.eclipse.org/bugs/show_bug.cgi?id=578874#c2 and found that this change may have negative impact: if the user cancels a JDT build the next autobuild will be a full build, because jdt is not able to resume a canceled autobuild. With this change the auto-interrupt was elevated to a cancel. It may not what the user wants. I was not aware that there was a reason to not use autointerrupt JDT build. I think it would be better to revert this change and have a more thoughtful look from JDTs side what can be done (grace period?) in bug 578874. WDYT?
(In reply to Jörg Kubitz from comment #4) > *I think it would be better to revert this change* > > Today i tested https://bugs.eclipse.org/bugs/show_bug.cgi?id=578874#c2 and > found that this change may have negative impact: if the user cancels a JDT > build the next autobuild will be a full build, because jdt is not able to > resume a canceled autobuild. > > With this change the auto-interrupt was elevated to a cancel. It may not > what the user wants. I was not aware that there was a reason to not use > autointerrupt JDT build. Please create dedicated bug for that & proceed with revert. Full build after cancel is surely too much.
