Community
Participate
Working Groups
Created attachment 288009 [details] Application default tab Environment: Windows11 English Steps to reproduce 1. Choose High Contrast theme "Aquatic" from Windows Settings > Accessibility > High Contrast Theme and Apply 2. Back to Eclipse, open Model Spy and Form tab 3. Open Default tab of Application White is used for the Back ground and some labels are invisible. Supplementary tab has the same issue.
Olivier/Lars, can you have a look?
IMO, this can very well be an issue with CSS coloring. Also double check if this can be fixed by tweaking high-contrast.css file.
Lars, can you have a look?
(In reply to Niraj Modi from comment #2) > IMO, this can very well be an issue with CSS coloring. > Also double check if this can be fixed by tweaking high-contrast.css file. I attempted a fix in high-contrast.css and found a potential solution. Will share a gerrit patch shortly.
New Gerrit change created: https://git.eclipse.org/r/c/platform/eclipse.platform.ui/+/191947
Created attachment 288223 [details] With patch Win10_HighContrast_ModelSpy_Application_default_tab (In reply to Eclipse Genie from comment #5) > New Gerrit change created: > https://git.eclipse.org/r/c/platform/eclipse.platform.ui/+/191947 With the fix, sharing the screen-shot of Model Spy Form tab dialog under high contrast theme.
(In reply to Niraj Modi from comment #6) > Created attachment 288223 [details] > With patch Win10_HighContrast_ModelSpy_Application_default_tab > > (In reply to Eclipse Genie from comment #5) > > New Gerrit change created: > > https://git.eclipse.org/r/c/platform/eclipse.platform.ui/+/191947 > > With the fix, sharing the screen-shot of Model Spy Form tab dialog under > high contrast theme. Can you share an image without this patch?
Created attachment 288224 [details] Without patch Win10_HighContrast_ModelSpy_Application_default_tab Without the fix.
Gerrit change https://git.eclipse.org/r/c/platform/eclipse.platform.ui/+/191947 was merged to [master]. Commit: http://git.eclipse.org/c/platform/eclipse.platform.ui.git/commit/?id=363418b210cb53bee06e5b204db9260a392df720
New Gerrit change created: https://git.eclipse.org/r/c/platform/eclipse.platform.ui/+/191856
(In reply to Eclipse Genie from comment #10) > New Gerrit change created: > https://git.eclipse.org/r/c/platform/eclipse.platform.ui/+/191856 Above is back-port gerrit patch for 'R4_23_maintenance' branch.
(In reply to Eclipse Genie from comment #9) > Gerrit change > https://git.eclipse.org/r/c/platform/eclipse.platform.ui/+/191947 was merged > to [master]. > Commit: > http://git.eclipse.org/c/platform/eclipse.platform.ui.git/commit/ > ?id=363418b210cb53bee06e5b204db9260a392df720 Above fix can be verified in below and onward Eclipse 4.24 IBuild: https://download.eclipse.org/eclipse/downloads/drops4/I20220316-1800/
Created attachment 288228 [details] Windows11 Desert theme Windows11 provides 5 high contrast themes. In I20220318-1800, I've verified that this issue was fixed on Aquatic, Dusk, Night sky and pink night sky theme which have black background. However Desert theme which has white background isn't fixed.
(In reply to Masayuki Fuse from comment #13) > Created attachment 288228 [details] > Windows11 Desert theme > > Windows11 provides 5 high contrast themes. In I20220318-1800, I've verified > that this issue was fixed on Aquatic, Dusk, Night sky and pink night sky > theme which have black background. > > However Desert theme which has white background isn't fixed. Thanks Masayuki for verifying this patch on all high-contrast themes. Since high-contrast(Black) being major we continue with the pure dark background and will back-port to 4.23+ As per our quick discussion, for the issue high-contrast(White) will raise a separate bug which might be considered for evaluation in future releases. Thanks!
Gerrit change https://git.eclipse.org/r/c/platform/eclipse.platform.ui/+/191856 was merged to [R4_23_maintenance]. Commit: http://git.eclipse.org/c/platform/eclipse.platform.ui.git/commit/?id=35a04d05ccf5dd5043d39c259f5f96b41fd67989
Thanks Niraj, I understand for the white background potential issue. I've verified the fixed for black black background.
(In reply to Masayuki Fuse from comment #16) > Thanks Niraj, > I understand for the white background potential issue. > I've verified the fixed for black black background. Raised bug 579288 to track the corner scenario with high-contrast(White) and it's possible work-around is mentioned at: https://bugs.eclipse.org/bugs/show_bug.cgi?id=579288#c2 Thanks Masayuki for all your help with the verification here.
