Bug 577894 - Backport Bug 577341 from 4.22 to 4.6
Summary: Backport Bug 577341 from 4.22 to 4.6
Status: REOPENED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: Debug (show other bugs)
Version: 4.23   Edit
Hardware: All All
: P3 normal (vote)
Target Milestone: 4.6.3+   Edit
Assignee: Sarika Sinha CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2021-12-19 12:54 EST by Sarika Sinha CLA
Modified: 2022-01-27 14:32 EST (History)
1 user (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Sarika Sinha CLA 2021-12-19 12:54:42 EST
Fix for Bug 577341 needs to be back ported from 4.22 branch to 4.7 branch.
Comment 1 Eclipse Genie CLA 2021-12-19 12:59:15 EST
New Gerrit change created: https://git.eclipse.org/r/c/platform/eclipse.platform.debug/+/188342
Comment 2 Eclipse Genie CLA 2021-12-19 12:59:57 EST
New Gerrit change created: https://git.eclipse.org/r/c/platform/eclipse.platform.debug/+/188343
Comment 3 Eclipse Genie CLA 2021-12-19 13:00:08 EST
New Gerrit change created: https://git.eclipse.org/r/c/platform/eclipse.platform.debug/+/188344
Comment 4 Eclipse Genie CLA 2021-12-19 13:00:19 EST
New Gerrit change created: https://git.eclipse.org/r/c/platform/eclipse.platform.debug/+/188345
Comment 5 Eclipse Genie CLA 2021-12-19 13:00:40 EST
New Gerrit change created: https://git.eclipse.org/r/c/platform/eclipse.platform.debug/+/188346
Comment 6 Eclipse Genie CLA 2021-12-19 13:01:02 EST
New Gerrit change created: https://git.eclipse.org/r/c/platform/eclipse.platform.debug/+/188347
Comment 7 Eclipse Genie CLA 2021-12-19 13:01:13 EST
New Gerrit change created: https://git.eclipse.org/r/c/platform/eclipse.platform.debug/+/188348
Comment 8 Eclipse Genie CLA 2021-12-19 13:01:24 EST
New Gerrit change created: https://git.eclipse.org/r/c/platform/eclipse.platform.debug/+/188349
Comment 9 Eclipse Genie CLA 2021-12-19 13:01:45 EST
New Gerrit change created: https://git.eclipse.org/r/c/platform/eclipse.platform.debug/+/188350
Comment 10 Eclipse Genie CLA 2021-12-19 13:01:57 EST
New Gerrit change created: https://git.eclipse.org/r/c/platform/eclipse.platform.debug/+/189011
Comment 11 Eclipse Genie CLA 2021-12-19 13:07:08 EST
New Gerrit change created: https://git.eclipse.org/r/c/platform/eclipse.platform.ui/+/189013
Comment 12 Eclipse Genie CLA 2021-12-19 13:07:10 EST
New Gerrit change created: https://git.eclipse.org/r/c/platform/eclipse.platform.ui/+/189014
Comment 13 Eclipse Genie CLA 2021-12-19 13:07:11 EST
New Gerrit change created: https://git.eclipse.org/r/c/platform/eclipse.platform.ui/+/189015
Comment 14 Eclipse Genie CLA 2021-12-19 13:07:12 EST
New Gerrit change created: https://git.eclipse.org/r/c/platform/eclipse.platform.ui/+/189016
Comment 15 Eclipse Genie CLA 2021-12-22 22:27:26 EST
New Gerrit change created: https://git.eclipse.org/r/c/platform/eclipse.platform.debug/+/189092
Comment 16 Eclipse Genie CLA 2021-12-22 22:42:39 EST
New Gerrit change created: https://git.eclipse.org/r/c/platform/eclipse.platform.debug/+/189093
Comment 17 Eclipse Genie CLA 2021-12-22 22:50:52 EST
New Gerrit change created: https://git.eclipse.org/r/c/platform/eclipse.platform.debug/+/189094
Comment 18 Eclipse Genie CLA 2021-12-22 22:56:04 EST
New Gerrit change created: https://git.eclipse.org/r/c/platform/eclipse.platform.debug/+/189095
Comment 19 Eclipse Genie CLA 2021-12-22 23:05:16 EST
New Gerrit change created: https://git.eclipse.org/r/c/platform/eclipse.platform.debug/+/189096
Comment 20 Eclipse Genie CLA 2021-12-22 23:17:29 EST
New Gerrit change created: https://git.eclipse.org/r/c/platform/eclipse.platform.debug/+/189097
Comment 21 Eclipse Genie CLA 2021-12-23 01:43:28 EST
New Gerrit change created: https://git.eclipse.org/r/c/platform/eclipse.platform.ui/+/189017
Comment 22 Eclipse Genie CLA 2021-12-24 05:00:18 EST
New Gerrit change created: https://git.eclipse.org/r/c/platform/eclipse.platform.debug/+/189120
Comment 23 Eclipse Genie CLA 2021-12-24 06:57:19 EST
New Gerrit change created: https://git.eclipse.org/r/c/platform/eclipse.platform.debug/+/189121
Comment 36 Eclipse Genie CLA 2021-12-24 09:23:59 EST
New Gerrit change created: https://git.eclipse.org/r/c/platform/eclipse.platform.debug/+/189122
Comment 39 Eclipse Genie CLA 2021-12-24 09:30:04 EST
New Gerrit change created: https://git.eclipse.org/r/c/platform/eclipse.platform.debug/+/189123
Comment 41 Eclipse Genie CLA 2021-12-24 14:17:08 EST
New Gerrit change created: https://git.eclipse.org/r/c/platform/eclipse.platform.debug/+/189127
Comment 43 Eclipse Genie CLA 2021-12-24 14:24:31 EST
New Gerrit change created: https://git.eclipse.org/r/c/platform/eclipse.platform.debug/+/189128
Comment 44 Eclipse Genie CLA 2021-12-27 08:39:20 EST
New Gerrit change created: https://git.eclipse.org/r/c/platform/eclipse.platform.debug/+/189161
Comment 46 Eclipse Genie CLA 2021-12-27 08:54:45 EST
New Gerrit change created: https://git.eclipse.org/r/c/platform/eclipse.platform.debug/+/189162
Comment 48 Eclipse Genie CLA 2021-12-27 08:58:39 EST
New Gerrit change created: https://git.eclipse.org/r/c/platform/eclipse.platform.debug/+/189019
Comment 50 Eclipse Genie CLA 2021-12-28 13:55:27 EST
New Gerrit change created: https://git.eclipse.org/r/c/platform/eclipse.platform.debug/+/189174
Comment 53 Eclipse Genie CLA 2021-12-28 14:03:54 EST
New Gerrit change created: https://git.eclipse.org/r/c/platform/eclipse.platform.debug/+/189020
Comment 54 Eclipse Genie CLA 2021-12-29 02:06:15 EST
New Gerrit change created: https://git.eclipse.org/r/c/platform/eclipse.platform.debug/+/189178
Comment 57 Eclipse Genie CLA 2021-12-29 02:10:50 EST
New Gerrit change created: https://git.eclipse.org/r/c/platform/eclipse.platform.debug/+/189021
Comment 58 Eclipse Genie CLA 2021-12-29 02:26:02 EST
New Gerrit change created: https://git.eclipse.org/r/c/platform/eclipse.platform.debug/+/189179
Comment 61 Eclipse Genie CLA 2021-12-29 05:01:23 EST
New Gerrit change created: https://git.eclipse.org/r/c/platform/eclipse.platform.debug/+/189183
Comment 64 Eclipse Genie CLA 2022-01-04 10:20:08 EST
New Gerrit change created: https://git.eclipse.org/r/c/platform/eclipse.platform.ui/+/189028
Comment 65 Eclipse Genie CLA 2022-01-04 10:23:20 EST
New Gerrit change created: https://git.eclipse.org/r/c/platform/eclipse.platform.ui/+/189254
Comment 68 Eclipse Genie CLA 2022-01-04 10:31:26 EST
New Gerrit change created: https://git.eclipse.org/r/c/platform/eclipse.platform.ui/+/189255
Comment 70 Eclipse Genie CLA 2022-01-04 10:52:00 EST
New Gerrit change created: https://git.eclipse.org/r/c/platform/eclipse.platform.ui/+/189256
Comment 75 Eclipse Genie CLA 2022-01-04 12:57:32 EST
New Gerrit change created: https://git.eclipse.org/r/c/platform/eclipse.platform.ui/+/189259
Comment 78 Eclipse Genie CLA 2022-01-04 13:02:07 EST
New Gerrit change created: https://git.eclipse.org/r/c/platform/eclipse.platform.ui/+/189260
Comment 81 Eclipse Genie CLA 2022-01-04 13:05:02 EST
New Gerrit change created: https://git.eclipse.org/r/c/platform/eclipse.platform.ui/+/189030
Comment 82 Eclipse Genie CLA 2022-01-04 13:24:15 EST
New Gerrit change created: https://git.eclipse.org/r/c/platform/eclipse.platform.ui/+/189261
Comment 86 Eclipse Genie CLA 2022-01-04 13:38:04 EST
New Gerrit change created: https://git.eclipse.org/r/c/platform/eclipse.platform.debug/+/189263
Comment 87 Eclipse Genie CLA 2022-01-04 13:38:25 EST
New Gerrit change created: https://git.eclipse.org/r/c/platform/eclipse.platform.ui/+/189271
Comment 90 Eclipse Genie CLA 2022-01-04 23:43:39 EST
New Gerrit change created: https://git.eclipse.org/r/c/platform/eclipse.platform.debug/+/189292
Comment 91 Eclipse Genie CLA 2022-01-04 23:44:51 EST
New Gerrit change created: https://git.eclipse.org/r/c/platform/eclipse.platform.ui/+/189293
Comment 94 Eclipse Genie CLA 2022-01-04 23:46:26 EST
New Gerrit change created: https://git.eclipse.org/r/c/platform/eclipse.platform.ui/+/189272
Comment 97 Eclipse Genie CLA 2022-01-05 02:18:29 EST
New Gerrit change created: https://git.eclipse.org/r/c/platform/eclipse.platform.ui/+/189294
Comment 99 Eclipse Genie CLA 2022-01-05 02:20:22 EST
New Gerrit change created: https://git.eclipse.org/r/c/platform/eclipse.platform.ui/+/189274
Comment 103 Eclipse Genie CLA 2022-01-05 05:28:24 EST
New Gerrit change created: https://git.eclipse.org/r/c/platform/eclipse.platform.ui/+/189300
Comment 105 Eclipse Genie CLA 2022-01-05 05:46:11 EST
New Gerrit change created: https://git.eclipse.org/r/c/platform/eclipse.platform.ui/+/189275
Comment 107 Eclipse Genie CLA 2022-01-05 06:38:26 EST
New Gerrit change created: https://git.eclipse.org/r/c/platform/eclipse.platform.ui/+/189304
Comment 109 Eclipse Genie CLA 2022-01-05 06:39:09 EST
New Gerrit change created: https://git.eclipse.org/r/c/platform/eclipse.platform.ui/+/189276
Comment 111 Eclipse Genie CLA 2022-01-05 06:55:10 EST
New Gerrit change created: https://git.eclipse.org/r/c/platform/eclipse.platform.ui/+/189307
Comment 113 Eclipse Genie CLA 2022-01-05 06:56:23 EST
New Gerrit change created: https://git.eclipse.org/r/c/platform/eclipse.platform.ui/+/189277
Comment 115 Eclipse Genie CLA 2022-01-05 13:08:00 EST
New Gerrit change created: https://git.eclipse.org/r/c/platform/eclipse.platform.ui/+/189318
Comment 117 Eclipse Genie CLA 2022-01-05 13:09:13 EST
New Gerrit change created: https://git.eclipse.org/r/c/platform/eclipse.platform.ui/+/189278
Comment 119 Eclipse Genie CLA 2022-01-05 13:12:06 EST
New Gerrit change created: https://git.eclipse.org/r/c/platform/eclipse.platform.ui/+/189319
Comment 121 Eclipse Genie CLA 2022-01-05 13:14:20 EST
New Gerrit change created: https://git.eclipse.org/r/c/platform/eclipse.platform.ui/+/189279
Comment 123 Eclipse Genie CLA 2022-01-05 13:21:45 EST
New Gerrit change created: https://git.eclipse.org/r/c/platform/eclipse.platform.ui/+/189280
Comment 125 Sarika Sinha CLA 2022-01-05 13:38:31 EST
All the changes for Platform Debug and UI have been back ported to 4.22, 4.21, 4.20, 4.19, 4.18, 4.17, 4.16, 4.15, 4.14, 4.13, 4.12, 4.11, 4.10, 4.9, 4.8 and 4.7.
Comment 126 Sarika Sinha CLA 2022-01-06 00:22:04 EST
Needs to be back ported to 4.6 Maintenance also.
Comment 127 Eclipse Genie CLA 2022-01-06 00:26:06 EST
New Gerrit change created: https://git.eclipse.org/r/c/platform/eclipse.platform.ui/+/189281
Comment 129 Eclipse Genie CLA 2022-01-06 00:27:59 EST
New Gerrit change created: https://git.eclipse.org/r/c/platform/eclipse.platform.debug/+/189334
Comment 131 Eclipse Genie CLA 2022-01-06 00:29:23 EST
New Gerrit change created: https://git.eclipse.org/r/c/platform/eclipse.platform.debug/+/189282
Comment 133 Kit Lo CLA 2022-01-06 15:37:55 EST
My local build for R4_6_maintenance failed with the following messages:

[ERROR] Failed to execute goal org.eclipse.tycho:tycho-compiler-plugin:0.25.0:compile (default-compile) on project org.eclipse.debug.core: Compilation failure: Compilation failure:
[ERROR] /lts/git-eclipse/R4_6_maintenance/eclipse.platform.debug/org.eclipse.debug.core/core/org/eclipse/debug/internal/core/XMLMemento.java:[75]
[ERROR]         boolean exists = Arrays.asList(strOldValue.split(",")).stream().anyMatch(x -> x.trim().equals(FILE_STRING)); //$NON-NLS-1$
[ERROR]                                                                ^^^^^^
[ERROR] The method stream() is undefined for the type List<String>
[ERROR] /lts/git-eclipse/R4_6_maintenance/eclipse.platform.debug/org.eclipse.debug.core/core/org/eclipse/debug/internal/core/XMLMemento.java:[75]
[ERROR]         boolean exists = Arrays.asList(strOldValue.split(",")).stream().anyMatch(x -> x.trim().equals(FILE_STRING)); //$NON-NLS-1$
[ERROR]                                                                                  ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[ERROR] Lambda expressions are allowed only at source level 1.8 or above
[ERROR] 2 problems (2 errors)
Comment 134 Sarika Sinha CLA 2022-01-07 01:37:54 EST
(In reply to Kit Lo from comment #133)
> My local build for R4_6_maintenance failed with the following messages:
> 
> [ERROR] Failed to execute goal
> org.eclipse.tycho:tycho-compiler-plugin:0.25.0:compile (default-compile) on
> project org.eclipse.debug.core: Compilation failure: Compilation failure:
> [ERROR]
> /lts/git-eclipse/R4_6_maintenance/eclipse.platform.debug/org.eclipse.debug.
> core/core/org/eclipse/debug/internal/core/XMLMemento.java:[75]
> [ERROR]         boolean exists =
> Arrays.asList(strOldValue.split(",")).stream().anyMatch(x ->
> x.trim().equals(FILE_STRING)); //$NON-NLS-1$
> [ERROR]                                                                ^^^^^^
> [ERROR] The method stream() is undefined for the type List<String>
> [ERROR]
> /lts/git-eclipse/R4_6_maintenance/eclipse.platform.debug/org.eclipse.debug.
> core/core/org/eclipse/debug/internal/core/XMLMemento.java:[75]
> [ERROR]         boolean exists =
> Arrays.asList(strOldValue.split(",")).stream().anyMatch(x ->
> x.trim().equals(FILE_STRING)); //$NON-NLS-1$
> [ERROR]                                                                     
> ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
> [ERROR] Lambda expressions are allowed only at source level 1.8 or above
> [ERROR] 2 problems (2 errors)

Eclipse was moved to Java 8 in 4.6 but Platform Debug was still at Java 7. Is it possible to to build with Java 8? 
Else will have to change the code to use Java 7 constructs.
Comment 135 Kit Lo CLA 2022-01-07 09:23:47 EST
(In reply to Sarika Sinha from comment #134)
> Eclipse was moved to Java 8 in 4.6 but Platform Debug was still at Java 7.
> Is it possible to to build with Java 8? 
> Else will have to change the code to use Java 7 constructs.

I was building with Java 8. However, I believe the bree for Platform Debug is still 1.7.
Comment 136 Eclipse Genie CLA 2022-01-17 02:14:16 EST
New Gerrit change created: https://git.eclipse.org/r/c/platform/eclipse.platform.debug/+/189698
Comment 138 Sarika Sinha CLA 2022-01-17 02:24:12 EST
(In reply to Kit Lo from comment #135)
> (In reply to Sarika Sinha from comment #134)
> > Eclipse was moved to Java 8 in 4.6 but Platform Debug was still at Java 7.
> > Is it possible to to build with Java 8? 
> > Else will have to change the code to use Java 7 constructs.
> 
> I was building with Java 8. However, I believe the bree for Platform Debug
> is still 1.7.

Lambda expression has been converted to anonymous class declaration and change has been released to the branch.
Comment 139 Kit Lo CLA 2022-01-20 17:29:37 EST
I'm still receiving the following errors:

[ERROR] Failed to execute goal org.eclipse.tycho:tycho-compiler-plugin:0.25.0:compile (default-compile) on project org.eclipse.debug.core: Compilation failure: Compilation failure:
[ERROR] /lts/git-eclipse/R4_6_maintenance/eclipse.platform.debug/org.eclipse.debug.core/core/org/eclipse/debug/internal/core/XMLMemento.java:[20]
[ERROR]         import java.util.function.Predicate;
[ERROR]                ^^^^^^^^^^^^^^^^^^
[ERROR] The import java.util.function cannot be resolved
[ERROR] /lts/git-eclipse/R4_6_maintenance/eclipse.platform.debug/org.eclipse.debug.core/core/org/eclipse/debug/internal/core/XMLMemento.java:[76]
[ERROR]         boolean exists = Arrays.asList(strOldValue.split(",")).stream().anyMatch(new Predicate<String>() { //$NON-NLS-1$
[ERROR]                                                                ^^^^^^
[ERROR] The method stream() is undefined for the type List<String>
[ERROR] /lts/git-eclipse/R4_6_maintenance/eclipse.platform.debug/org.eclipse.debug.core/core/org/eclipse/debug/internal/core/XMLMemento.java:[76]
[ERROR]         boolean exists = Arrays.asList(strOldValue.split(",")).stream().anyMatch(new Predicate<String>() { //$NON-NLS-1$
[ERROR]                                                                                      ^^^^^^^^^
[ERROR] Predicate cannot be resolved to a type
[ERROR] /lts/git-eclipse/R4_6_maintenance/eclipse.platform.debug/org.eclipse.debug.core/core/org/eclipse/debug/internal/core/XMLMemento.java:[78]
[ERROR]         public boolean test(String x) {
[ERROR]                        ^^^^^^^^^^^^^^
[ERROR] The method test(String) of type new Predicate<String>(){} must override or implement a supertype method
[ERROR] 4 problems (4 errors)
Comment 140 Sarika Sinha CLA 2022-01-21 06:24:51 EST
ok, surprisingly it didn't show for me in local workspace with Java 7 compliance.
But error looks genuine, will fix them.
Comment 141 Eclipse Genie CLA 2022-01-27 14:31:07 EST
New Gerrit change created: https://git.eclipse.org/r/c/platform/eclipse.platform.debug/+/190084
Comment 143 Sarika Sinha CLA 2022-01-27 14:32:18 EST
(In reply to Sarika Sinha from comment #140)
> ok, surprisingly it didn't show for me in local workspace with Java 7
> compliance.
> But error looks genuine, will fix them.

Fixed.