Bug 577572 - Context menu that's 4 level or more cannot be hidden
Summary: Context menu that's 4 level or more cannot be hidden
Status: NEW
Alias: None
Product: Platform
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 4.20   Edit
Hardware: PC Windows 10
: P3 normal (vote)
Target Milestone: ---   Edit
Assignee: Platform-UI-Inbox CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2021-12-01 13:30 EST by Page CLA
Modified: 2021-12-01 13:30 EST (History)
0 users

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Page CLA 2021-12-01 13:30:55 EST 
We have some context menu that has 4 levels, and it is set to be hidden for some conditions, however it is still visible but upon selecting it becomes disabled.

Looks like it's related to bug https://bugs.eclipse.org/bugs/show_bug.cgi?id=34969 where it's purposely setting it as disabled (see code in org.eclipse.jface.action.MenuManager::updateMenuItem()).

And it's hardcoded in eclipse code to only process menus up-to 3 levels, see org.eclipse.e4.ui.workbench.renderers.swt.MenuManagerShowProcessor::showMenu() where the recursiveLevel is 2 (starting index 0).

We would like those context menus to be hidden as defined based on visibleWhen clause not just disabled.