Bug 577431 - [GTK4] TabFolder not taking full width
Summary: [GTK4] TabFolder not taking full width
Status: VERIFIED FIXED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: SWT (show other bugs)
Version: 4.23   Edit
Hardware: PC Linux
: P3 normal (vote)
Target Milestone: 4.23 M1   Edit
Assignee: Joel Majano CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: 540385
  Show dependency tree
 
Reported: 2021-11-24 12:22 EST by Alexander Kurtakov CLA
Modified: 2022-01-06 09:55 EST (History)
2 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Alexander Kurtakov CLA 2021-11-24 12:22:40 EST 
Seen in ControlExample tabs not taking full width when maximized.
Comment 1 Joel Majano CLA 2021-11-24 12:26:26 EST 
Some behavior I noticed:

- Dragging the window to make it bigger correctly expands the area the widgets use
- When maximized, the size stays the same as when it was when not maximized, even if the window was made bigger by dragging one of the corners
Comment 2 Joel Majano CLA 2021-11-29 12:18:50 EST 
This is definitely an issue with CTabFolder, as running snippet 82 results in many GLib critical messages. The tab closing functionality is also broken, and this also exhibits the same "Unable to take up full width" behavior as seen in ControlExample.
Comment 3 Alexander Kurtakov CLA 2021-11-29 12:23:40 EST 
(In reply to Joel Majano from comment #2)
> This is definitely an issue with CTabFolder, as running snippet 82 results
> in many GLib critical messages. The tab closing functionality is also
> broken, and this also exhibits the same "Unable to take up full width"
> behavior as seen in ControlExample.

CTabFolder would be different issue as ControlExample uses TabFolder and not CTabFolder. Or the issue lies deeper and is exposed by both.
Comment 4 Joel Majano CLA 2021-11-29 13:23:30 EST 
(In reply to Alexander Kurtakov from comment #3)
> (In reply to Joel Majano from comment #2)
> > This is definitely an issue with CTabFolder, as running snippet 82 results
> > in many GLib critical messages. The tab closing functionality is also
> > broken, and this also exhibits the same "Unable to take up full width"
> > behavior as seen in ControlExample.
> 
> CTabFolder would be different issue as ControlExample uses TabFolder and not
> CTabFolder. Or the issue lies deeper and is exposed by both.

Ah yes, you would be correct, it is an issue with TabFolder. Snippet 76 shows the same erroneous behaviour, and without the list of errors when launched. Thanks for the note on CTabFolder vs TabFolder in ControlExample.
Comment 5 Joel Majano CLA 2021-11-29 13:56:17 EST 
My last comment was incorrect, Snippet 76 ONLY shows this behavior if shell.setLayout(new FillLayout()) is added right after shell is created. This is an issue with FillLayout().
Comment 6 Eclipse Genie CLA 2021-11-29 17:07:09 EST 
New Gerrit change created: https://git.eclipse.org/r/c/platform/eclipse.platform.swt/+/188297
Comment 8 Joel Majano CLA 2022-01-06 09:55:55 EST 
Verified in latest I20220106-0000.