Community
Participate
Working Groups
We see unstable test results and failures on Windows/Linux, introduced via bug 576945. https://download.eclipse.org/eclipse/downloads/drops4/I20211109-1800/testresults/html/org.eclipse.debug.tests_ep422I-unit-cen64-gtk3-java11_linux.gtk.x86_64_11.html N/A java.lang.AssertionError at org.junit.Assert.fail(Assert.java:87) at org.junit.Assert.assertTrue(Assert.java:42) at org.junit.Assert.assertTrue(Assert.java:53) at org.eclipse.debug.tests.console.RuntimeProcessTests.testOutputAfterDestroy(RuntimeProcessTests.java:235) https://download.eclipse.org/eclipse/downloads/drops4/I20211109-1800/testresults/html/org.eclipse.debug.tests_ep422I-unit-win32-java11_win32.win32.x86_64_11.html expected:<-1> but was:<76> java.lang.AssertionError: expected:<-1> but was:<76> at org.junit.Assert.fail(Assert.java:89) at org.junit.Assert.failNotEquals(Assert.java:835) at org.junit.Assert.assertEquals(Assert.java:647) at org.junit.Assert.assertEquals(Assert.java:633) at org.eclipse.debug.tests.console.RuntimeProcessTests.testOutputAfterDestroy(RuntimeProcessTests.java:232) Torbjörn: could you please check?
@Torbjörn, Can you look at this? Else we will have to disable this test.
Also fails on Mac, see https://download.eclipse.org/eclipse/downloads/drops4/I20211109-1800/testresults/html/org.eclipse.debug.tests_ep422I-unit-mac64-java17_macosx.cocoa.x86_64_17.html N/A java.lang.AssertionError at org.junit.Assert.fail(Assert.java:87) at org.junit.Assert.assertTrue(Assert.java:42) at org.junit.Assert.assertTrue(Assert.java:53) at org.eclipse.debug.tests.console.RuntimeProcessTests.testOutputAfterDestroy(RuntimeProcessTests.java:235)
This test is failing because (as identified when fix went in for Bug 576945[1]) the problem is much improved, but not 100% fixed. MockProcess has a comment on line 182 about adding a sleep - with that sleep the test fails reliably. I suspect that the test should be disabled for now until other issues can be resolved. @Torbjörn - do you agree with this conclusion? Also, we should have a bug about the remaining issue identified (that it is still possible to miss some output) [1] https://git.eclipse.org/r/c/platform/eclipse.platform.debug/+/187134/6#message-442a1a8f86505087075b577e92aff70e4d241f21 [2] https://git.eclipse.org/r/c/platform/eclipse.platform.debug/+/187134/6/org.eclipse.debug.tests/src/org/eclipse/debug/tests/console/MockProcess.java
If the test case is that unreliable, I suppose we should disable it for now. I've executed it several times on at least 3 different systems (2 Linux and 1 Windows 10) and so far, I've not got any failure as long as the commented sleep was not used. Regarding the remaining error; @Jonah, can you create that bug as I think you had an idea on how to solve it.
OK - I will create a bug and disable the test.
Because I mentioned two bugs in commit comment the gerrit was attributed to the other bug. Manually entering the gerrit to disable test here. @Sarika - I assume it is ok to submit disabling this test for M3? I have provisionally changed the Target Milestone.
Thanks Andrey for raising this, and for reviewing/merging the gerrit.
(In reply to Jonah Graham from comment #6) > Because I mentioned two bugs in commit comment the gerrit was attributed to > the other bug. Manually entering the gerrit to disable test here. > > @Sarika - I assume it is ok to submit disabling this test for M3? I have > provisionally changed the Target Milestone. Thanks!
