Bug 577081 - Change default to use the external browser instead of the internal browser of Eclipse
Summary: Change default to use the external browser instead of the internal browser of...
Status: RESOLVED FIXED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 4.22   Edit
Hardware: PC Linux
: P3 normal (vote)
Target Milestone: 4.22 M3   Edit
Assignee: Lars Vogel CLA
QA Contact:
URL:
Whiteboard:
Keywords: noteworthy
Depends on:
Blocks: 575807
  Show dependency tree
 
Reported: 2021-11-05 04:42 EDT by Lars Vogel CLA
Modified: 2022-09-12 08:27 EDT (History)
8 users (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Lars Vogel CLA 2021-11-05 04:42:25 EDT
Currently Eclipse preferences states to use the internal browser instead of the external browser.

Is this useful? I never, ever use the internal browser in Eclipse, it the normal browser buttons, preferences, etc. 

If more people think the same way, we should change the default to use the default system browser.
Comment 1 Lars Vogel CLA 2021-11-05 04:44:01 EDT
Defaulting to the external browser would also simplify my Git PR workflow as per default the link in the EGit push dialog to create a PR would jump to my real browser which has my Github user.
Comment 2 Lars Vogel CLA 2021-11-05 06:01:52 EDT
Short survey on twitter indicate that most people would prefer a new default https://twitter.com/vogella/status/1456542956433952771
Comment 3 Eclipse Genie CLA 2021-11-05 06:31:23 EDT
New Gerrit change created: https://git.eclipse.org/r/c/platform/eclipse.platform.ui/+/187385
Comment 4 Eclipse Genie CLA 2021-11-05 07:05:56 EDT
New Gerrit change created: https://git.eclipse.org/r/c/www.eclipse.org/eclipse/news/+/187388
Comment 7 Eclipse Genie CLA 2021-11-05 08:56:06 EDT
New Gerrit change created: https://git.eclipse.org/r/c/platform/eclipse.platform.ui/+/187394
Comment 8 Eclipse Genie CLA 2021-11-05 08:56:08 EDT
New Gerrit change created: https://git.eclipse.org/r/c/platform/eclipse.platform.ui/+/187395
Comment 11 Andrey Loskutov CLA 2021-11-09 05:18:36 EST
(In reply to Eclipse Genie from comment #5)
> Gerrit change
> https://git.eclipse.org/r/c/platform/eclipse.platform.ui/+/187385 was merged
> to [master].
> Commit:
> http://git.eclipse.org/c/platform/eclipse.platform.ui.git/commit/
> ?id=a2b25899e99bd9bc292d56a08e181878c9111068

I wonder we should reconsider this in light of bug 577124.

Also I'm not sure the new workflow makes sense and should be changed before we flip the default: 

1) Create new html file
2) After creation, Eclipse IDE will be hidden by opened browser.

That is not "IDE" anymore. I expect that IDE doesn't jump to the browser after I've created new file that I'm supposed to *edit*.
Comment 12 Mauro Molinari CLA 2021-11-09 05:23:54 EST
(In reply to Andrey Loskutov from comment #11)
> 1) Create new html file
> 2) After creation, Eclipse IDE will be hidden by opened browser.
> 
> That is not "IDE" anymore. I expect that IDE doesn't jump to the browser
> after I've created new file that I'm supposed to *edit*.

But isn't this problem more related to the fact that the browser is started on the newly created HTML file, rather than the fact that the external vs internal browser is used?
It would be annoying even if the internal browser were started just after I create a new HTML file.
Comment 13 Lars Vogel CLA 2021-11-09 10:49:25 EST
(In reply to Mauro Molinari from comment #12)
> (In reply to Andrey Loskutov from comment #11)
> > 1) Create new html file
> > 2) After creation, Eclipse IDE will be hidden by opened browser.

> It would be annoying even if the internal browser were started just after I
> create a new HTML file.

+1, opening a browser if I click or create a HTML file in an IDE is silly in both cases. Maybe we can register the (Generic) test editor as (low-priority) editor for html files. Opened Bug 577149 for that.
Comment 14 Mickael Istria CLA 2021-11-10 09:23:46 EST
> Also I'm not sure the new workflow makes sense and should be changed before
> we flip the default: 
> 
> 1) Create new html file
> 2) After creation, Eclipse IDE will be hidden by opened browser.
> 
> That is not "IDE" anymore. I expect that IDE doesn't jump to the browser
> after I've created new file that I'm supposed to *edit*.

I don't think this is particularly worse than showing the internal browser. After all, by default Eclipse Platform doesn't have an editor for HTML files, so there is no particular reason it keeps the attention on itself.
Same thing happens for many other formats: system viewer or editor opens when creating the file from the IDE, because the IDE isn't better than the system viewer. It's a good thing to default to best available tool on the system instead of keeping user stuck to the IDE that's not much going to help them immediately.
Comment 15 Jonah Graham CLA 2021-11-10 09:30:42 EST
+1 to Comment 14 - this is something that applies equally to .sh files and probably many others. Probably the default for these types of files should be to open in the editor, but the best solution for that is to have wwd (for html) and shellwax (for .sh) installed.

I think this is one significant place that Eclipse is different from a text editor. In a text editor everything should open in the editor by default.
Comment 16 Vikas Chandra CLA 2021-11-11 03:49:15 EST
>>That is not "IDE" anymore. I expect that IDE doesn't jump to the browser after 

We should have "use internal browser" by default( as before). Going back and forth the eclipse IDE is tedious. Then I had to find out which preference option controls this. 

Most of the times, an user would prefer  "use internal browser". Hence that should be the default option selected.
Comment 17 Lars Vogel CLA 2021-11-11 03:56:45 EST
(In reply to Vikas Chandra from comment #16)
> >>That is not "IDE" anymore. I expect that IDE doesn't jump to the browser after 

> Most of the times, an user would prefer  "use internal browser". Hence that
> should be the default option selected.

How do you came to this result?

If you look at the user feedback in https://twitter.com/vogella/status/1456542956433952771, you see that the answer of the users were clearly in favor of the external browser.
Comment 18 Mauro Molinari CLA 2021-11-11 04:31:48 EST
(In reply to Vikas Chandra from comment #16)
> Most of the times, an user would prefer  "use internal browser". Hence that
> should be the default option selected.

Is anybody really using the internal browser to do actual web development?
I personally find it quite useless, but it's IMHO.
Comment 19 Jonah Graham CLA 2021-11-11 13:57:38 EST
(In reply to Mauro Molinari from comment #18)
> Is anybody really using the internal browser to do actual web development?
> I personally find it quite useless, but it's IMHO.

Yes, but the uselessness is probably because the internal browser has (more and more) issues. See Bug 574611 for which the workaround is to use the external browser.