Bug 576921 - Dynamic toolbar controls are not resized correctly if there are items with FORCE_TEXT
Summary: Dynamic toolbar controls are not resized correctly if there are items with FO...
Status: NEW
Alias: None
Product: Platform
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 4.21   Edit
Hardware: PC Windows 10
: P3 normal (vote)
Target Milestone: ---   Edit
Assignee: Platform-UI-Inbox CLA
QA Contact:
URL:
Whiteboard:
Keywords: needinfo, regression
Depends on:
Blocks:
 
Reported: 2021-10-27 10:41 EDT by Marc Ernst CLA
Modified: 2021-11-12 02:30 EST (History)
3 users (show)

See Also:


Attachments
Plugin with dynamic toolbar item and about button with forced text (3.14 KB, application/octet-stream)
2021-11-11 02:33 EST, Marc Ernst CLA
no flags Details
Screenshot using the reproducer plug-in (9.62 KB, image/png)
2021-11-11 02:36 EST, Marc Ernst CLA
no flags Details
Screenshot using the reproducer plug-in and Eclipse 4.22 (13.27 KB, image/png)
2021-11-12 02:30 EST, Marc Ernst CLA
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Marc Ernst CLA 2021-10-27 10:41:19 EDT
I've created a dynamic toolbar control. It was working fine with 4.20 but with the current version not all the toolbar icons are shown, the toolbar is just cut at some size. The toolbar looks like it is not resized correctly. The other toolbar items except the dynamic toolbar item have the flag mode="FORCE_TEXT". If I remove it everything gets resized correctly.
Comment 1 Andrey Loskutov CLA 2021-10-27 10:56:01 EDT
Please provide a small self contained project or snippet that shows the issue. Could be either SWT issue or some "optimization" in the UI renderer.
Comment 2 Rolf Theunissen CLA 2021-11-08 05:45:27 EST
Most likely also an regression of Bug 574641, this case might be fixed already.

Does the problem still reproduce in 4.22? Please provide the example to validate it.
Comment 3 Marc Ernst CLA 2021-11-11 02:33:22 EST
Created attachment 287488 [details]
Plugin with dynamic toolbar item and about button with forced text

Sorry I did not had time to look into it until now. I uploaded a little plug-in as reproducer. It adds a toolbar with a dynamic contribution item and an about button with forced text. When you launch it, you can see that the dynamic contribution item hides the about button. Couldn't check yet with newest version.
Comment 4 Marc Ernst CLA 2021-11-11 02:36:45 EST
Created attachment 287489 [details]
Screenshot using the reproducer plug-in
Comment 5 Marc Ernst CLA 2021-11-12 02:30:07 EST
Created attachment 287499 [details]
Screenshot using the reproducer plug-in and Eclipse 4.22

Tried with latest Eclipse 4.22 (11/11). Looks a bit different, the icon is now shown but still the text is cut. Attached a screenshot.