Bug 57688 - [Viewers] TableViewer framwork should support new SWT Table capabilities
Summary: [Viewers] TableViewer framwork should support new SWT Table capabilities
Status: VERIFIED FIXED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 3.0   Edit
Hardware: All All
: P4 enhancement with 1 vote (vote)
Target Milestone: 3.1 M1   Edit
Assignee: Tod Creasey CLA
QA Contact:
URL:
Whiteboard:
Keywords: helpwanted, investigate
: 58655 (view as bug list)
Depends on:
Blocks:
 
Reported: 2004-04-06 22:51 EDT by David Mechner CLA
Modified: 2004-09-21 10:55 EDT (History)
8 users (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description David Mechner CLA 2004-04-06 22:51:02 EDT
The TableViewer framework should support the new capabilities of the SWT Table
widget: the VIRTUAL style, per-cell foreground and background color and font. As
it is now, users have to choose between the viewer framework and the highly
desirable table features.
Comment 1 Tod Creasey CLA 2004-04-07 09:58:09 EDT
We likely do not have time to do this in the 3.0 timeframe
Comment 2 David Mechner CLA 2004-04-07 10:26:09 EDT
Is there any chance for guidance on how the API will look? We're starting a
project where the central component is a TableTree, and would like to use the 
Viewer framework! We could make our own modifications, but it would be nice to
have what we do match up with the ultimate release at least give or take some
refactoring..
Comment 3 Tod Creasey CLA 2004-04-07 10:49:54 EDT
Kim has looked into this and might have some suggestions
Comment 4 Kim Horne CLA 2004-04-07 10:55:14 EDT
I'd wager we'd create ITableColorProvider and ITableFontProvider, which would
behave similarly to ITableLabelProvider.  In the table viewer implementation
we'd check to see if your ITableColorProvider was also an instance of these two
and alter the TableItem properties accordingly.
Comment 5 David Mechner CLA 2004-04-07 11:03:12 EDT
I see. And how about the VIRTUAL table style? Wouldn't taking advantage of this
imply a change to the content provider interface?

Comment 6 Kim Horne CLA 2004-04-07 11:32:38 EDT
I'm afraid I'm not well aquainted enough with VIRTUAL to make the call there...
bounce back to Tod?
Comment 7 Tod Creasey CLA 2004-04-07 14:06:56 EDT
Neither am I. Either way this is a large amount of work that we likely will 
not get to until 3.1
Comment 8 Ben Youngdahl CLA 2004-04-09 22:16:45 EDT
Does SWT.VIRTUAL make much sense in terms of a table with sorting applied by the
TableViewer?  In order to perform the sorting, the table viewer is going to have
to roll through all the items, which defeats the purpose of SWT.VIRTUAL.  

Of course, a table viwer could start its life without sorting, playing nice with
SWT.VIRTUAL.  If sorting is then applied to the TableViewer, the result might be
quite expensive time-wise.  Something tells me that the sorting on a massive
table may be best done on a seperate thread than the UI.  I can see how this
would get complicated.

Filtering would be nice to have with SWT.VIRTUAL, and that looks easier.

Just as an aside -- I feel very strongly that Eclipse would be well served by
resources being put behind completing a world-class Table, Tree, and TableTree
implementation.  Certainly most business RCP apps need these particular widgets
to be second-to-none in terms of power and flexibility, and this is one area
where Swing (especially with 3rd party controls) has SWT beat at the moment.  I
realize some of this enhancement has been done in 3.0, but it feels to me like
there is a long way to go and this isn't a particularly high priority.  That
concerns me.
Comment 9 Kim Horne CLA 2004-04-15 12:26:53 EDT
*** Bug 58655 has been marked as a duplicate of this bug. ***
Comment 10 Tod Creasey CLA 2004-06-28 11:27:15 EDT
Reopening now that 3.0 has shipped
Comment 11 Akram BEN AISSI CLA 2004-07-15 06:14:18 EDT
Can you give an example of "per-cell foreground and background color and font"
The interface IColorProvider requires the implementation of the methods public
Color getForeground(Object arg0) and public Color getBackground(Object arg0)
which don't specify the column index.

So how can you do this?


Comment 12 Tod Creasey CLA 2004-07-15 08:36:21 EDT
We have released the ITableColorProvider into the 3.1. stream to handle this 
sort of thing.
Comment 13 Ed Burnette CLA 2004-08-23 14:21:29 EDT
Is this the same as bug 72358?
Comment 14 Tod Creasey CLA 2004-08-23 15:02:26 EDT
Thanks Ed - now it is as we have addressed the other features.

I am going to close this as all except SWT.VIRTUAL support is done - please 
feel free to add yourself if you interested to Bug 72358.
Comment 15 Tod Creasey CLA 2004-09-21 10:55:30 EDT
Verified the support in 20040921