Bug 576318 - history selection tracking suddenly tracks fields and methods
Summary: history selection tracking suddenly tracks fields and methods
Status: NEW
Alias: None
Product: Platform
Classification: Eclipse Project
Component: Team (show other bugs)
Version: 3.0   Edit
Hardware: All All
: P3 normal (vote)
Target Milestone: ---   Edit
Assignee: Platform Team Inbox CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2021-09-29 04:02 EDT by Michael Keppler CLA
Modified: 2021-09-29 05:55 EDT (History)
2 users (show)

See Also:


Attachments
screenshot (56.21 KB, image/png)
2021-09-29 04:02 EDT, Michael Keppler CLA
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Michael Keppler CLA 2021-09-29 04:02:42 EDT
Created attachment 287226 [details]
screenshot

In my history view, "Link with editor and Selection" has always been enabled, and it used to work for repository, file and editor selections.

Today I noticed for the first time that this now also reacts to selecting a method/field in the java outline view. Unfortunately that always produces an empty history. For reproduction you may need to select different methods multiple times, it seems the history always shows the previously selected method.

I'm not sure when exactly that changed and whether that is egit or platform.

See attached screenshot
Comment 1 Andrey Loskutov CLA 2021-09-29 04:10:38 EDT
It was always in the platform, but it got worse with egit 4.13 or 4.12, because egit stopped to show history for the editor.

Previously, history was "restored" after editor -> outline -> editor selection.
Now you have to find the edited file in some navigator to get the history back - *that* is annoying.
Comment 2 Thomas Wolf CLA 2021-09-29 04:29:33 EDT
I presume you mean 5.12/5.13. Cannot reproduce; editor->outline->editor properly shows the file history again.
Comment 3 Thomas Wolf CLA 2021-09-29 04:30:39 EDT
Of course, I'm on OS X. Perhaps it depends on the OS.
Comment 4 Andrey Loskutov CLA 2021-09-29 04:45:44 EDT
(In reply to Thomas Wolf from comment #2)
> I presume you mean 5.12/5.13. Cannot reproduce; editor->outline->editor
> properly shows the file history again.

That's interesting. I saw this behavior yesterday last time, now tried to reproduce - no way. I swear, I was really angry because of this.

Anyway, the other thing with "local history for selected method" is annoying as well. I wonder if that should be disabled by default if there is a team provider for given editor, but I have no idea where that is configured. Most likely in platform, not egit, except egit misses to contribute to some extension point.
Comment 5 Thomas Wolf CLA 2021-09-29 05:22:42 EDT
(In reply to Andrey Loskutov from comment #4)
> Anyway, the other thing with "local history for selected method" is annoying
> as well. I wonder if that should be disabled by default if there is a team
> provider for given editor, but I have no idea where that is configured. Most
> likely in platform, not egit, except egit misses to contribute to some
> extension point.

I'm not sure it's related to team providers at all. The "not found" message refers to "local history". It means there is no local history for that file. Edit a method, save, then go to the outline view again. Now it'll show a datetime, and there's a compare action.
Comment 6 Andrey Loskutov CLA 2021-09-29 05:55:45 EDT
(In reply to Thomas Wolf from comment #5)
> (In reply to Andrey Loskutov from comment #4)
> > Anyway, the other thing with "local history for selected method" is annoying
> > as well. I wonder if that should be disabled by default if there is a team
> > provider for given editor, but I have no idea where that is configured. Most
> > likely in platform, not egit, except egit misses to contribute to some
> > extension point.
> 
> I'm not sure it's related to team providers at all. The "not found" message
> refers to "local history". It means there is no local history for that file.
> Edit a method, save, then go to the outline view again. Now it'll show a
> datetime, and there's a compare action.

Anyway, then it should go to platform resources or platfrom team (?) and that "feature" should be disabled by default if a team provider is installed, or via preference. I've never had any use for this, and with "right" team providers the  switching off "right" history is a constant pain.