Bug 576213 - ShellFactory cannot create shell for a display
Summary: ShellFactory cannot create shell for a display
Status: RESOLVED FIXED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 4.22   Edit
Hardware: All All
: P3 normal (vote)
Target Milestone: ---   Edit
Assignee: Marcus Höpfner CLA
QA Contact:
URL:
Whiteboard:
Keywords: api
Depends on:
Blocks:
 
Reported: 2021-09-23 04:29 EDT by Lars Vogel CLA
Modified: 2022-10-13 07:44 EDT (History)
3 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Lars Vogel CLA 2021-09-23 04:29:35 EDT 
The JFace ShellFactory does not allow to create a shell for a display.

Shell shell = new Shell(display, SWT.NO_TRIM);

IMHO this is a common use case, e.g. in pure SWT and JFace applications, see for example https://git.eclipse.org/c/platform/eclipse.platform.swt.git/tree/examples/org.eclipse.swt.snippets/src/org/eclipse/swt/snippets/Snippet164.java

Can this be fixed to support the following:
			ShellFactory.newShell(SWT.NO_TRIM).text(shellText).create(display);
Comment 1 Lars Vogel CLA 2021-09-23 04:31:55 EDT 
Marcus, WDYT?
Comment 2 Eclipse Genie CLA 2021-09-28 08:18:43 EDT 
New Gerrit change created: https://git.eclipse.org/r/c/platform/eclipse.platform.ui/+/185892
Comment 3 Mickael Istria CLA 2021-11-10 09:39:51 EST 
Too late for 4.22; API additions need to be completed before M3 completes (except if approved by PMC).
Comment 4 Marcus Höpfner CLA 2022-10-13 07:44:35 EDT 
Done with https://github.com/eclipse-platform/eclipse.platform.ui/pull/408