Community
Participate
Working Groups
When working with a launch configuration holding a large number of environment variables, the table controls aren't as quick to work with as possible. Although it's possible to remove multiple variables and paste new pairs in, sometimes it's just more straightforward to have a big text field with everything in it.
Can you please add a screenshot as attachment how it looks like after your proposed change?
Created attachment 287031 [details] before
Created attachment 287032 [details] after,1
Created attachment 287033 [details] after,2
I like the Idea. I always used crtl+A (select all) "Copy" Button Paste into Texteditor (Edit) Copy from Texteditor "Paste" Button for that. The centered Table/Text switch looks unusual. Would it not feel more eclipse-like to have a "Edit as Text" Button below the "Edit.." Button on the right to open a modal Text Edit Dialog instead? (Like the "Show Command Line" in the bottom)
(In reply to Jörg Kubitz from comment #5) > The centered Table/Text switch looks unusual. The centered switching is a style of the macOS platform; the same control is used on the API Errors/Warnings preference page. > Would it not feel more > eclipse-like to have a "Edit as Text" Button below the "Edit.." Button on > the right to open a modal Text Edit Dialog instead? (Like the "Show Command > Line" in the bottom) The intent is to present this as two different ways of looking at, and modifying, the same information. Clicking a button and opening a model dialog over the already model launch config dialog is not really the user experience I'm going for. Granted, the tab folder might not be the right control for that.
If one tries to use same key in text mode twice content is lost with "!ENTRY org.eclipse.ui 4 0 2021-09-07 23:01:20.948 !MESSAGE Unhandled event loop exception !STACK 0 java.lang.IllegalStateException: Duplicate key fds (attempted merging values fdadf and fadsf) at java.base/java.util.stream.Collectors.duplicateKeyException(Collectors.java:133) at java.base/java.util.stream.Collectors.lambda$uniqKeysMapAccumulator$1(Collectors.java:180) at java.base/java.util.stream.ReduceOps$3ReducingSink.accept(ReduceOps.java:169) at java.base/java.util.ArrayList$ArrayListSpliterator.forEachRemaining(ArrayList.java:1655) at java.base/java.util.stream.AbstractPipeline.copyInto(AbstractPipeline.java:484) at java.base/java.util.stream.AbstractPipeline.wrapAndCopyInto(AbstractPipeline.java:474) at java.base/java.util.stream.ReduceOps$ReduceOp.evaluateSequential(ReduceOps.java:913) at java.base/java.util.stream.AbstractPipeline.evaluate(AbstractPipeline.java:234) at java.base/java.util.stream.ReferencePipeline.collect(ReferencePipeline.java:578) at org.eclipse.debug.ui.EnvironmentTab.addVariables(EnvironmentTab.java:674) at org.eclipse.debug.ui.EnvironmentTab.updateTableFromText(EnvironmentTab.java:892) at org.eclipse.debug.ui.EnvironmentTab.lambda$0(EnvironmentTab.java:301)"
Created attachment 287104 [details] UI on Linux with the patch
(In reply to Alexander Kurtakov from comment #8) > Created attachment 287104 [details] > UI on Linux with the patch I like the idea but the TabFolder looks even more weird on Linux(and it's most likely not centered on Windows too). Once acceptable "switcher" is found this would be very nice addition.
The most common choice is either Combo or Radio button but none of them is pretty (not that tabfolder is)
E.g. on the Keys preference page Combo is used to switch between schemes. This looks like closest to this case.
We have so many tabbed pages in preference page, any configuration to make it look good on linux on those? Can we do apply the same here? Combo I feel is not so intuitive and does not appeal that there exists 2 ways in the first view. Radio button at least will show the options but may not look good either. @Nitin, Can you add the duplicate key check?
(In reply to Sarika Sinha from comment #12) > @Nitin, > Can you add the duplicate key check? What should happen on a duplicate?
(In reply to Nitin Dahyabhai from comment #13) > (In reply to Sarika Sinha from comment #12) > > @Nitin, > > Can you add the duplicate key check? > > What should happen on a duplicate? In the table view, we don't allow 2 variables with same name, so here also we cannot allow. We can show an error for "Duplicate variable name" and disable the "Apply" button till the error is resolved.
Created attachment 288280 [details] Current Patch Moving to Github, gerrit needs to be migrated.
@Nitin, Do you plan to take this forward? github repo is https://github.com/eclipse-platform/eclipse.platform.debug
(In reply to Sarika Sinha from comment #16) > @Nitin, > Do you plan to take this forward? > github repo is https://github.com/eclipse-platform/eclipse.platform.debug I have every intention, but no plan at the moment. I'm swamped on my own project.
