Bug 575373 - Less lines/border in the compare editor widgets
Summary: Less lines/border in the compare editor widgets
Status: NEW
Alias: None
Product: Platform
Classification: Eclipse Project
Component: Compare (show other bugs)
Version: 4.21   Edit
Hardware: All All
: P3 enhancement (vote)
Target Milestone: ---   Edit
Assignee: Platform-Compare-Inbox CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2021-08-12 05:35 EDT by Mickael Istria CLA
Modified: 2021-08-16 06:46 EDT (History)
0 users

See Also:

Attachments
Before patch (current master) (250.96 KB, image/png)
2021-08-12 15:26 EDT, Mickael Istria CLA 		no flags Details
After patch (251.46 KB, image/png)
2021-08-12 15:27 EDT, Mickael Istria CLA 		no flags Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Mickael Istria CLA 2021-08-12 05:35:41 EDT 
The compare editor seems heavy. One reason is that it has plenty of widgets showing borders, resulting in more lines drawn, a few pixels wasted; while the value of this border on readability seems arguable.
The compare editor should be reviewed to reduce the amount of lines it shows, and hence feel a bit lighter.
Comment 1 Eclipse Genie CLA 2021-08-12 15:24:47 EDT 
New Gerrit change created: https://git.eclipse.org/r/c/platform/eclipse.platform.team/+/183971
Comment 2 Mickael Istria CLA 2021-08-12 15:26:49 EDT 
Created attachment 286927 [details]
Before patch (current master)
Comment 3 Mickael Istria CLA 2021-08-12 15:27:57 EDT 
Created attachment 286928 [details]
After patch

Those screenshot do show current proposal gets rid of a few heavy lines and save 2 pixels in width/height.
Some extra lines could still be removed (in further patches).
Comment 4 Mickael Istria CLA 2021-08-16 06:46:30 EDT 
One issue I see here is that the TextViewers themselves are delegated to extensions (eg Java or other editors), but those extensions usually don't set the SWT.BORDER styles for the widgets and there is no good way to forward the style from editor to viewers.
So it's a bit tricky to remove some of the lines while emulating a border.