Bug 575352 - [win32][dark them] Display.h*Theme methods do not respect dark theme
Summary: [win32][dark them] Display.h*Theme methods do not respect dark theme
Status: NEW
Alias: None
Product: Platform
Classification: Eclipse Project
Component: SWT (show other bugs)
Version: 4.20   Edit
Hardware: PC Windows 10
: P3 normal (vote)
Target Milestone: ---   Edit
Assignee: Platform-SWT-Inbox CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: 577357
  Show dependency tree
 
Reported: 2021-08-11 02:53 EDT by Rolf Theunissen CLA
Modified: 2022-01-18 06:14 EST (History)
2 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Rolf Theunissen CLA 2021-08-11 02:53:49 EDT 
The Display.h*Theme use the hwndMessage handle to obtain theme descriptions. This handle is not marked with AllowDarkModeForWindow nor is a SetWindowTheme with a dark theme set.

I am pretty sure that this must cause some glitches in the dark theme, or there have been made workarounds for these glitches. Also, having global themes for the full display may not be the windows API is intended to be used.

Note that I don't have the intention to fix this myself, just don't have enough knowledge about the win32 APIs.
Comment 1 Alexandr Miloslavskiy CLA 2021-11-10 17:40:21 EST 
That's an interesting find, thanks!

Luckily, currently 'Display.hScrollBarTheme' is the only theme that is currently relevant to SWT's Dark Theme. And the only place where it's used is 'Button' with 'SWT.ARROW' style. A rare beast, I imagine, that's why I never noticed it.

I acknowledged this finding, but I think that I'm not ready to take any action here. I'll just wait till it gets in the way of my Dark Theme work.