Bug 575171 - [Win32][Combo] Cursor is not at the end of the path for AUTO_TEXT_DIRECTION
Summary: [Win32][Combo] Cursor is not at the end of the path for AUTO_TEXT_DIRECTION
Status: VERIFIED FIXED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: SWT (show other bugs)
Version: 4.11   Edit
Hardware: PC Windows 10
: P3 normal with 6 votes (vote)
Target Milestone: 4.22 M1   Edit
Assignee: Niraj Modi CLA
QA Contact:
URL:
Whiteboard:
Keywords: regression
Depends on:
Blocks:
 
Reported: 2021-08-02 05:00 EDT by Marc Ernst CLA
Modified: 2021-09-21 04:14 EDT (History)
4 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Marc Ernst CLA 2021-08-02 05:00:17 EDT 
The patch to fix bug https://bugs.eclipse.org/bugs/show_bug.cgi?id=545035 (setting SWT.AUTO_TEXT_DIRECTION) introduces another bug that if you enter a workspace path in the chooser dialog, the cursor stays at the end of the combo box and does not at the end of the path.
Comment 1 Marc Ernst CLA 2021-08-06 01:51:39 EDT 
I would like to start a discussion how this issue can be solved. I guess removing SWT.AUTO_TEXT_DIRECTION is not an option as it would reopen the other bug. JFace Bidi support is not available at this stage. Any other proposals how this can be solved? I can help to create a patch.
Comment 2 Marc Ernst CLA 2021-08-23 10:13:09 EDT 
Anybody who can help to fix this bug? I guess it requires native changes.
Comment 3 Andrey Loskutov CLA 2021-08-23 12:32:19 EDT 
Kalyan, could you please take a look?
Comment 4 Kalyan Prasad Tatavarthi CLA 2021-08-24 03:49:59 EDT 
Investigated on the combo code. Found that the cursor position is pointing to the end of the text and pressing the left arrow takes the cursor to the end of the text. 

Looks like some redraw is not happening as expected.

So Moving to SWT for further investigation and adding Niraj in the CC List.
Comment 5 Niraj Modi CLA 2021-09-09 05:41:18 EDT 
(In reply to Kalyan Prasad Tatavarthi from comment #4)
> Investigated on the combo code. Found that the cursor position is pointing
> to the end of the text and pressing the left arrow takes the cursor to the
> end of the text. 
> 
Combo with AUTO_TEXT_DIRECTION, should automatically scrolls selection's end into view even for longer text, which is not the case currently:
- Hence we need to force it to do such scrolling, to make sure Caret no longer goes out of view.

I have a working fix for this, will share a gerrit shortly.
Comment 6 Eclipse Genie CLA 2021-09-09 05:43:06 EDT 
New Gerrit change created: https://git.eclipse.org/r/c/platform/eclipse.platform.swt/+/185204
Comment 8 Niraj Modi CLA 2021-09-09 06:11:12 EDT 
Resolving now.
Comment 9 Niraj Modi CLA 2021-09-21 04:14:30 EDT 
Verified in Eclipse Build id: I20210920-1800 on Win10