Bug 574815 - [macOS] Dock context menu does not show shells any more
Summary: [macOS] Dock context menu does not show shells any more
Status: NEW
Alias: None
Product: Platform
Classification: Eclipse Project
Component: SWT (show other bugs)
Version: 4.21   Edit
Hardware: PC Mac OS X
: P3 normal (vote)
Target Milestone: ---   Edit
Assignee: Platform-SWT-Inbox CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2021-07-13 06:10 EDT by Thomas Singer CLA
Modified: 2021-07-14 08:48 EDT (History)
5 users (show)

See Also:


Attachments
Snippet to reproduce (544 bytes, text/plain)
2021-07-13 06:10 EDT, Thomas Singer CLA
no flags Details
Screenshot for SWT v4932r13 - good (32.88 KB, image/png)
2021-07-13 06:12 EDT, Thomas Singer CLA
no flags Details
Screenshot for SWT v4932r14 - bad (23.85 KB, image/png)
2021-07-13 06:12 EDT, Thomas Singer CLA
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Thomas Singer CLA 2021-07-13 06:10:10 EDT
Please launch the attached snippet on macOS (tried 10.14.6) with SWT v4932r13. 2 shells should occur. Right-click the Dock icon and you will see them listed. Now use SWT v4932r14 and the entries for the shells in the Dock icon popup are gone.
Comment 1 Thomas Singer CLA 2021-07-13 06:10:46 EDT
Created attachment 286773 [details]
Snippet to reproduce
Comment 2 Thomas Singer CLA 2021-07-13 06:12:09 EDT
Created attachment 286774 [details]
Screenshot for SWT v4932r13 - good
Comment 3 Thomas Singer CLA 2021-07-13 06:12:35 EDT
Created attachment 286775 [details]
Screenshot for SWT v4932r14 - bad
Comment 4 Niraj Modi CLA 2021-07-14 06:18:43 EDT
Hi Nikita,
Do you see if any of below patches would have caused this issue seen with attachment 286773 [details] on MAC ?

Between v4932r13 and v4932r14 below two commits have MAC related changes:
https://git.eclipse.org/c/platform/eclipse.platform.swt.git/commit/?id=30ad38d69b91bac02f587cec89b564c73a903bdb

https://git.eclipse.org/c/platform/eclipse.platform.swt.git/commit/?id=552c841cdec57d1445d04f981fead6cc3fbd21c8
Comment 5 Nikita Nemkin CLA 2021-07-14 06:33:55 EDT
Hi Niraj.

The first change only affects SWT_AWT, which the repro snipped doesn't use.
The second change is completely neutral, shouldn't have any observable effect.

Maybe removing "-framework JavaVM" from LDFLAGS in the SWT_AWT patch triggered some internal compatibility change?
Comment 6 Eclipse Genie CLA 2021-07-14 07:11:40 EDT
New Gerrit change created: https://git.eclipse.org/r/c/platform/eclipse.platform.swt/+/183053
Comment 7 Niraj Modi CLA 2021-07-14 08:48:05 EDT
(In reply to Nikita Nemkin from comment #5)
> Hi Niraj.
> 
> The first change only affects SWT_AWT, which the repro snipped doesn't use.
> The second change is completely neutral, shouldn't have any observable
> effect.
> 
> Maybe removing "-framework JavaVM" from LDFLAGS in the SWT_AWT patch
> triggered some internal compatibility change?

Checked with Sravan on "-framework JavaVM" usage: It has been removed from Xcode 12.2(needed for aarch64 support).
And putting this flag back causes the native MAC build to fail.

So to narrow it down further, we will need to revert the mentioned patches in comment 4 and confirm if any of this has cause this issue. Thanks!

Any other ideas are welcome here.