Bug 574685 - [Table|Tree|CTabFolder|ToolBar|MenuItem] Tooltips on dark mode are hard to read
Summary: [Table|Tree|CTabFolder|ToolBar|MenuItem] Tooltips on dark mode are hard to read
Status: VERIFIED FIXED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: SWT (show other bugs)
Version: 4.21   Edit
Hardware: PC Windows 10
: P3 enhancement (vote)
Target Milestone: 4.21 M3   Edit
Assignee: Niraj Modi CLA
QA Contact: Rolf Theunissen CLA
URL:
Whiteboard:
Keywords: noteworthy, plan, usability
: 566281 (view as bug list)
Depends on:
Blocks: 574014
  Show dependency tree
 
Reported: 2021-07-06 09:38 EDT by Gayan Perera CLA
Modified: 2021-08-19 03:27 EDT (History)
3 users (show)

See Also:

Attachments
Tooltip (29.73 KB, image/png)
2021-07-06 09:38 EDT, Gayan Perera CLA 		no flags Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Gayan Perera CLA 2021-07-06 09:38:34 EDT 
Created attachment 286739 [details]
Tooltip

In Tables in dark mode, the tooltips are hard to read. This is same on content assist popup and all other places where tables are used.
Comment 1 Niraj Modi CLA 2021-08-05 07:55:39 EDT 
*** Bug 566281 has been marked as a duplicate of this bug. ***
Comment 2 Niraj Modi CLA 2021-08-05 07:57:37 EDT 
Am working on a fix on this issue, will create a gerrit shortly.
Comment 3 Lars Vogel CLA 2021-08-05 08:12:13 EDT 
(In reply to Niraj Modi from comment #2)
> Am working on a fix on this issue, will create a gerrit shortly.

Awesome! Thanks.
Comment 4 Rolf Theunissen CLA 2021-08-05 08:25:32 EDT 
(In reply to Niraj Modi from comment #2)
> Am working on a fix on this issue, will create a gerrit shortly.

Wonderful, I had toyed around with this too never got to a final state. My last thoughts on this would be that it is as simple as enabling theming for the popup window.
Comment 5 Eclipse Genie CLA 2021-08-09 03:44:21 EDT 
New Gerrit change created: https://git.eclipse.org/r/c/platform/eclipse.platform.swt/+/183810
Comment 7 Rolf Theunissen CLA 2021-08-16 04:02:56 EDT 
Very nice work so far. Though I notice there are some more tooltips around that are still not dark, for instance on toolbars.

Related OS message identifiers:
LVM_GETTOOLTIPS
TB_GETTOOLTIPS
TCM_GETTOOLTIPS
TVM_GETTOOLTIPS

As noticed in my second version of the Gerrit, in Table#createHandle to create dark tooltips we should be able to call (instead of the current call on the callback):

	long hwndToolTip = OS.SendMessage (handle, OS.LVM_GETTOOLTIPS, 0, 0);
	maybeEnableDarkSystemTheme(hwndToolTip);

Something similar should be possible for other controls, e.g. for the Toolbar:

	long hwndToolTip = OS.SendMessage (handle, OS.TB_GETTOOLTIPS, 0, 0);
	maybeEnableDarkSystemTheme(hwndToolTip);


Given the time-window, another bug might be needed, although all dark is better then the current dark and light mix.
Comment 8 Niraj Modi CLA 2021-08-16 04:20:27 EDT 
Will shortly share gerrit change for ToolBar tooltip@dark theme as well.
Comment 9 Eclipse Genie CLA 2021-08-16 04:21:08 EDT 
New Gerrit change created: https://git.eclipse.org/r/c/platform/eclipse.platform.swt/+/184058
Comment 10 Lars Vogel CLA 2021-08-16 04:42:39 EDT 
Please also add to N&N. Dark theme users will like this change
Comment 12 Eclipse Genie CLA 2021-08-16 05:48:44 EDT 
New Gerrit change created: https://git.eclipse.org/r/c/www.eclipse.org/eclipse/news/+/184064
Comment 14 Eclipse Genie CLA 2021-08-16 06:08:17 EDT 
New Gerrit change created: https://git.eclipse.org/r/c/www.eclipse.org/eclipse/news/+/184067
Comment 16 Niraj Modi CLA 2021-08-16 06:28:49 EDT 
Done with N&N entries. Thanks Rolf for your inputs on this bug.
Resolving now.
Comment 17 Niraj Modi CLA 2021-08-17 03:11:49 EDT 
Verified on Windows using Build id: I20210816-1800
Comment 18 Lars Vogel CLA 2021-08-17 03:34:17 EDT 
Thanks, just tested on Windows and looks way better.
Comment 19 Rolf Theunissen CLA 2021-08-17 04:50:51 EDT 
Found another light tooltip, on the menu. For instance hover on 'File > Open file ...'. This one is triggered by menuItemToolTipHandle / createMenuItemToolTipHandle / createToolTip
Comment 20 Niraj Modi CLA 2021-08-17 07:33:40 EDT 
(In reply to Rolf Theunissen from comment #19)
> Found another light tooltip, on the menu. For instance hover on 'File > Open
> file ...'. This one is triggered by menuItemToolTipHandle /
> createMenuItemToolTipHandle / createToolTip

Thanks Rolf for the detailed testing, will release a patch shortly to handle this.
Comment 21 Eclipse Genie CLA 2021-08-17 08:01:20 EDT 
New Gerrit change created: https://git.eclipse.org/r/c/platform/eclipse.platform.swt/+/184134
Comment 23 Eclipse Genie CLA 2021-08-19 03:27:56 EDT 
New Gerrit change created: https://git.eclipse.org/r/c/www.eclipse.org/eclipse/news/+/184222