Community
Participate
Working Groups
Bug 511580 added support for dialog settings customization for products, due the nature of the patch (custom product preferences needed) there were no tests added. That was a fault from me. This feature is now broken again, due the change https://git.eclipse.org/r/c/platform/eclipse.platform.ui/+/166431 / commit http://git.eclipse.org/c/platform/eclipse.platform.ui.git/commit/?id=8266c76c0792ed71ee13bff1514e3c5cab3f4883 . The line 112 in DialogSettingsProvider only considers "instance" scope: https://git.eclipse.org/r/c/platform/eclipse.platform.ui/+/166431/18/bundles/org.eclipse.e4.ui.workbench.swt/src/org/eclipse/e4/ui/internal/workbench/swt/DialogSettingsProvider.java#112 but I see in the debugger that the product customized url is in the "default" scope. Note, that original code used org.eclipse.ui.PlatformUI.getPreferenceStore().getString("default_dialog_settings_rootUrl") that calls org.eclipse.ui.preferences.ScopedPreferenceStore.internalGet(String) that considers *both* instance AND default scopes for searching, see org.eclipse.ui.preferences.ScopedPreferenceStore.getPreferenceNodes(boolean). I plan to push a patch soon.
I remember discussing this while I made the patch but I can't find that discussion anymore. I'm sorry for the oversight. Let me know if you need help.
New Gerrit change created: https://git.eclipse.org/r/c/platform/eclipse.platform.ui/+/182551
Gerrit change https://git.eclipse.org/r/c/platform/eclipse.platform.ui/+/182551 was merged to [master]. Commit: http://git.eclipse.org/c/platform/eclipse.platform.ui.git/commit/?id=4c9e6977e7c1a742ad4e8f038c884e55ac45c7b1
Works again.
(In reply to Andrey Loskutov from comment #4) > Works again. Thanks, Andrey! Very much appreciated.
