Bug 573766 - Terminate/Disconnect All command is not enabled when there is active launches
Summary: Terminate/Disconnect All command is not enabled when there is active launches
Status: ASSIGNED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: Debug (show other bugs)
Version: 4.21   Edit
Hardware: All All
: P3 enhancement (vote)
Target Milestone: ---   Edit
Assignee: Jonah Graham CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on: 573561
Blocks:
  Show dependency tree
 
Reported: 2021-05-25 14:39 EDT by Jonah Graham CLA
Modified: 2022-03-18 15:09 EDT (History)
3 users (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Jonah Graham CLA 2021-05-25 14:39:19 EDT
+++ This bug was initially created as a clone of Bug #573561 +++

From https://git.eclipse.org/r/c/platform/eclipse.platform.debug/+/181000/3#message-2d964a71836a71b029e1d0e6ff1c6d9a4a24b4a5

> Patch Set 2:
> 
> > Patch Set 2:
> > 
> > That is better - however it exposes a problem and that terminate all only works if something is selected in the Debug View. So I am fine with this first step, but the TerminateAllAction needs to be enabled all the time, not dependent on a selection.
> > 
> > Perhaps that is a different bug though. I can do a local hack fix of adding
> > 
> > 	@Override
> > 	public void setEnabled(boolean enabled) {
> > 		super.setEnabled(true);
> > 	}
> > 
> > to TerminateAllAction, but I am not sure that is the right way to go about it :-)
> > 
> > Note you can reproduce the not enabled Terminate All in the context menu of the Debug View if nothing in the tree is selected, even if there are launches listed.
> 
> That's how the current "TerminateAll" works. It either works on selection of debug view or if focus is in Console view. so If you are ok with this we can release this?
> Some one will have to work on the other enhancement which works without selection.

So this is the bug to do that enhancement.


This came up when trying to resolve Bug 573303.
Comment 1 Jonah Graham CLA 2021-05-25 15:12:55 EDT
> It either works on selection of debug view or if focus is in Console view

Turns out even if focus is the console view, with no selection in the Debug View it isn't available.
Comment 2 Eclipse Genie CLA 2021-05-26 00:15:03 EDT
New Gerrit change created: https://git.eclipse.org/r/c/platform/eclipse.platform.debug/+/181035
Comment 3 Sarika Sinha CLA 2021-08-27 06:27:00 EDT
Please reassign the target once the patch is ready.
Comment 4 Jonah Graham CLA 2022-03-18 15:09:11 EDT
New branch for this work post gerrit: https://github.com/jonahgraham/eclipse.platform.debug/tree/Bug_573766_Terminate_All