Bug 573426 - HyperlinkFactory is missing in the WidgetFactories
Summary: HyperlinkFactory is missing in the WidgetFactories
Status: NEW
Alias: None
Product: Platform
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 4.21   Edit
Hardware: All All
: P3 normal (vote)
Target Milestone: ---   Edit
Assignee: Platform-UI-Inbox CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2021-05-07 08:52 EDT by Marcus Höpfner CLA
Modified: 2022-01-17 11:19 EST (History)
1 user (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Marcus Höpfner CLA 2021-05-07 08:52:36 EDT
Create a HyperlinkFactory (like ButtonFactory and co.)
Comment 1 Eclipse Genie CLA 2021-05-07 08:56:57 EDT
New Gerrit change created: https://git.eclipse.org/r/c/platform/eclipse.platform.ui/+/180358
Comment 2 Marcus Höpfner CLA 2021-05-10 02:53:36 EDT
There is a cycle dependency introduced in the commit.

Deja vu.
I remember that I have tried this a while ago already.

Following proposal:
- abandon the change and create a second WidgetFactory in o.e.ui.forms for the form widgets which are located in o.e.ui.forms.

BUT there is only a few potential form widgets for which it might make sense to have them in a factory.
IMHO this is Hyperlink ans Section. Do you see any value in created a second WidgetFactory in o.e.ui.forms.
This also introduce a naming issues if not better name than WidgetFactory is found for the second factory.

WDYT?
Comment 3 Lars Vogel CLA 2022-01-17 03:02:16 EST
I think we should move this factory to the forms plug-in. This would require to open up the factories to be implemented in other plug-ins but that is also nice for customer factories.
Comment 4 Marcus Höpfner CLA 2022-01-17 11:19:15 EST
Is it allowed w.r.t. stable APIs to move the whole widgetfactories?
I mean not only the abstract class, but all concrete implementations like ButtonFactory and LabelFactory and friends.

We can also try to move the framework parts to a common plugin and leave the concrete implementations in jface.