Bug 572953 - [e4][tooling] Add header check for new fragment header
Summary: [e4][tooling] Add header check for new fragment header
Status: NEW
Alias: None
Product: Platform
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 4.20   Edit
Hardware: PC Linux
: P3 normal (vote)
Target Milestone: ---   Edit
Assignee: Platform-UI-Inbox CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on: 572919
Blocks:
  Show dependency tree
 
Reported: 2021-04-19 03:57 EDT by Christoph Laeubrich CLA
Modified: 2021-04-19 04:40 EDT (History)
3 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Christoph Laeubrich CLA 2021-04-19 03:57:06 EDT 
Bug 571866 add possibility to register fragments via manifest headers and Bug 572946 adds wizard support.

It would be good to have additional checker that validates the existence of the file and its attributes.
Comment 1 Julian Honnen CLA 2021-04-19 04:01:56 EDT 
Implementing the new PDE extension point in e4 tools would introduce a dependency from Platform to PDE. Is that OK?
Comment 2 Alexander Fedorov CLA 2021-04-19 04:07:53 EDT 
(In reply to Julian Honnen from comment #1)
> Implementing the new PDE extension point in e4 tools would introduce a
> dependency from Platform to PDE. Is that OK?

Generally it is not OK, but I'm not sure that e4 tools is the part of the Platform. Please specify the exact pair of bundles that will have a dependency.
Comment 3 Mickael Istria CLA 2021-04-19 04:10:17 EDT 
(In reply to Julian Honnen from comment #1)
> Implementing the new PDE extension point in e4 tools would introduce a
> dependency from Platform to PDE. Is that OK?

No objection from me, but please ask others via the mailing-list.
I personally always thought that e4 tools in general should have been part of PDE more than Platform.
Comment 4 Christoph Laeubrich CLA 2021-04-19 04:26:43 EDT 
(In reply to Julian Honnen from comment #1)
> Implementing the new PDE extension point in e4 tools would introduce a
> dependency from Platform to PDE. Is that OK?

e4.core.tools currently depends on

> org.eclipse.pde.core;bundle-version="3.9.0",
> org.eclipse.pde.ui;bundle-version="3.8.0"

and even uses internal API, so I really don't see any reason to be much concerned here.
Comment 5 Alexander Fedorov CLA 2021-04-19 04:40:11 EDT 
(In reply to Christoph Laeubrich from comment #4)
> (In reply to Julian Honnen from comment #1)
> > Implementing the new PDE extension point in e4 tools would introduce a
> > dependency from Platform to PDE. Is that OK?
> 
> e4.core.tools currently depends on
> 
> > org.eclipse.pde.core;bundle-version="3.9.0",
> > org.eclipse.pde.ui;bundle-version="3.8.0"
> 
> and even uses internal API, so I really don't see any reason to be much
> concerned here.

So, nothing new from dependency POV, right?