Community
Participate
Working Groups
If more than one editor is dirty, the "Save Resources" dialog is shown when exiting (File > Exit) or when closing all editors (Ctrl+Shift+W): (a) In order not to save files/resources, you must first click on "Deselect All" and then on "Save Selected". It feels wrong to me when I have to click "Save Selected" for don't save. (b) The "Select All" button is enabled even when all resources are selected and the "Deselect All" button is enabled even when no resource is selected. Hitting the button in such a case will have no effect. (c) The button labels "Select All" and "Deselect All" make the concept of the selection explicit to the user: the resources to be saved must be added to the selection which then has to be confirmed. When asked which resources to save, I just want to say "All" or "None" instead of explicitly putting the resources into a selection that can then be submitted for saving.
New Gerrit change created: https://git.eclipse.org/r/c/platform/eclipse.platform.ui/+/179468
Created attachment 286160 [details] Screen shot of fix (In reply to Eclipse Genie from comment #1) > New Gerrit change created: > https://git.eclipse.org/r/c/platform/eclipse.platform.ui/+/179468 If you de-select all "Cancel" and "Don't Save" do the same. This feels a bit strange to me. But this was the same with "Cancel" and "Save Selected" to this we could live with this. But "Don't Save" is much better then "Save Selected" because nothing is saved in that case.
(In reply to Holger Voormann from comment #0) > If more than one editor is dirty, the "Save Resources" dialog is shown when > exiting (File > Exit) or when closing all editors (Ctrl+Shift+W): > > (a) In order not to save files/resources, you must first click on "Deselect > All" and then on "Save Selected". It feels wrong to me when I have to click > "Save Selected" for don't save. I have exactly the same feeling. Thanks so much for providing the change. Changing the label text to "Don't Save" makes absolutely sense and is much better compared to the existing behavior.
Gerrit change https://git.eclipse.org/r/c/platform/eclipse.platform.ui/+/179468 was merged to [master]. Commit: http://git.eclipse.org/c/platform/eclipse.platform.ui.git/commit/?id=a95e0c69db61a126303c357640fa0fbcaff3d700
Thanks, Holger. Super nice. Maybe add to N&N? I leave that decision to you.
