Bug 572515 - Fix JNA resolution error in Eclipse arm64 build
Summary: Fix JNA resolution error in Eclipse arm64 build
Status: VERIFIED FIXED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 4.20   Edit
Hardware: PC Mac OS X
: P3 normal (vote)
Target Milestone: 4.20 M1   Edit
Assignee: Sebastian Ratz CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on: 566100 568690
Blocks: 565690 572115
  Show dependency tree
 
Reported: 2021-04-01 03:23 EDT by Lakshmi P Shanmugam CLA
Modified: 2021-04-08 05:30 EDT (History)
5 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Lakshmi P Shanmugam CLA 2021-04-01 03:23:34 EDT 
Launching eclipse arm64 fails due to unresolved JNA dependency.

From https://bugs.eclipse.org/bugs/show_bug.cgi?id=572115#c10, this happens because the JNA version included in the SDK is 4.5.1 and doesn't support Mac arm64. 
We need to include the latest JNA 5.8 with Mac arm64 support or if possible remove the dependency.
Comment 1 Lakshmi P Shanmugam CLA 2021-04-01 03:51:59 EDT 
(In reply to Lakshmi P Shanmugam from comment #0)
> We need to include the latest JNA 5.8 with Mac arm64 support or if possible
> remove the dependency.

JNA dependency was added by Bug 558807.
@Sebastian, Can you please help resolve this issue?
Comment 2 Sravan Kumar Lakkimsetti CLA 2021-04-01 05:09:17 EDT 
There are two versions of JNA in Simrel 

4.5.1 coming from Eclipse Communication Framework
5.6.0 not sure where it is coming from

Eclipse platform uses JNA coming from ECF. It would be better if ECF upgrades their JNA to latest.
Comment 3 Sebastian Ratz CLA 2021-04-01 05:44:54 EDT 
I tried to bump the required version for platform already in 568690.

Why do we have to consume the version that ECF is using?

I agree that it would be nice to only have one version in the simrel, but if we have an explicit dependency to it, we should be able to consume whatever version we require, no matter what ECF does or does not.

Am I missing something here?
Comment 4 Sravan Kumar Lakkimsetti CLA 2021-04-01 05:49:40 EDT 
(In reply to Sebastian Ratz from comment #3)
> I tried to bump the required version for platform already in 568690.
> 
> Why do we have to consume the version that ECF is using?
> 
> I agree that it would be nice to only have one version in the simrel, but if
> we have an explicit dependency to it, we should be able to consume whatever
> version we require, no matter what ECF does or does not.
> 
> Am I missing something here?

We can go ahead with the latest version JNA in platform. Its good to get a single version in Simrel but if that is not possible it is better to use the version we need in platform.
Comment 5 Eclipse Genie CLA 2021-04-07 11:21:25 EDT 
New Gerrit change created: https://git.eclipse.org/r/c/platform/eclipse.platform.ui/+/178975
Comment 7 Lakshmi P Shanmugam CLA 2021-04-08 05:29:30 EDT 
Verified with I20210407-1800.
JNA 5.8 is included in the SDK and it fixes the resolution error in Mac arm64 build.

Thanks Sebastian for fixing this!