Bug 572326 - [GTK] TestUnitTreeColumnFactory.setsWidth fails since I20210325-1800
Summary: [GTK] TestUnitTreeColumnFactory.setsWidth fails since I20210325-1800
Status: VERIFIED FIXED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: SWT (show other bugs)
Version: 4.20   Edit
Hardware: PC Linux
: P3 normal (vote)
Target Milestone: 4.20 M1   Edit
Assignee: Soraphol (Paul) Damrongpiriyapong CLA
QA Contact:
URL:
Whiteboard:
Keywords: regression
Depends on:
Blocks: 568185
  Show dependency tree
 
Reported: 2021-03-26 06:26 EDT by Andrey Loskutov CLA
Modified: 2021-04-06 15:37 EDT (History)
1 user (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Andrey Loskutov CLA 2021-03-26 06:26:32 EDT 
Probably regression from bug 568185.

https://download.eclipse.org/eclipse/downloads/drops4/I20210325-1800/testresults/html/org.eclipse.jface.tests_ep420I-unit-cen64-gtk3-java11_linux.gtk.x86_64_11.html

expected:<20> but was:<0>

java.lang.AssertionError: expected:<20> but was:<0>
at org.junit.Assert.fail(Assert.java:89)
at org.junit.Assert.failNotEquals(Assert.java:835)
at org.junit.Assert.assertEquals(Assert.java:647)
at org.junit.Assert.assertEquals(Assert.java:633)
at org.eclipse.jface.tests.widgets.TestUnitTreeColumnFactory.setsWidth(TestUnitTreeColumnFactory.java:80)
Comment 1 Andrey Loskutov CLA 2021-03-26 06:27:20 EDT 
Paul, could you please check? Thanks!
Comment 2 Soraphol (Paul) Damrongpiriyapong CLA 2021-03-26 16:48:34 EDT 
Yep, a patch has been made that should fix the issue. 

https://git.eclipse.org/r/c/platform/eclipse.platform.swt/+/178438

If it turns out that it doesn't, we will revert back, and do a GTK4 specific solution.
Comment 3 Andrey Loskutov CLA 2021-03-27 07:15:32 EDT 
(In reply to Soraphol (Paul) Damrongpiriyapong from comment #2)
> Yep, a patch has been made that should fix the issue. 
> 
> https://git.eclipse.org/r/c/platform/eclipse.platform.swt/+/178438
> 
> If it turns out that it doesn't, we will revert back, and do a GTK4 specific
> solution.

Thanks Paul, that seem to work now!
Comment 4 Soraphol (Paul) Damrongpiriyapong CLA 2021-04-06 15:37:24 EDT 
Marking as verified, UI test is passing as of I20210405-1800.