Bug 571934 - AsyncCompletionProposalPopup.displayProposals() called twice
Summary: AsyncCompletionProposalPopup.displayProposals() called twice
Status: NEW
Alias: None
Product: Platform
Classification: Eclipse Project
Component: Text (show other bugs)
Version: 4.20   Edit
Hardware: PC Linux
: P3 normal (vote)
Target Milestone: ---   Edit
Assignee: Platform-Text-Inbox CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2021-03-13 07:40 EST by Stephan Herrmann CLA
Modified: 2021-03-13 07:41 EST (History)
0 users

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Stephan Herrmann CLA 2021-03-13 07:40:30 EST 
While debugging bug 569668 I noticed that AsyncCompletionProposalPopup.displayProposals() is called twice for the same popup, which looks wasteful at least - I measured several hundreds of milliseconds in the debugger (I did not observe an outright bug - yet).

This is caused by https://git.eclipse.org/c/platform/eclipse.platform.text.git/commit/?id=90e69fcf2b64d43dade977d6b1de50ae70c9d2f4 from bug 553577. More specifically, since that commit computeAndPopulateProposals() unconditionally at its end calls displayProposals() -- no matter that the same call may have happened before already.