Bug 571826 - [Sequence Diagram] Follow up of performance improvements done Sirius 6.4.0
Summary: [Sequence Diagram] Follow up of performance improvements done Sirius 6.4.0
Status: CLOSED FIXED
Alias: None
Product: Sirius
Classification: Modeling
Component: Diagram (show other bugs)
Version: 6.4.0   Edit
Hardware: PC Mac OS X
: P3 normal (vote)
Target Milestone: 6.5.0   Edit
Assignee: Maxime Porhel CLA
QA Contact: Glenn Plouhinec CLA
URL:
Whiteboard:
Keywords: triaged
Depends on:
Blocks:
 
Reported: 2021-03-09 15:31 EST by Maxime Porhel CLA
Modified: 2021-06-02 02:43 EDT (History)
1 user (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Maxime Porhel CLA 2021-03-09 15:31:43 EST 
Several performance improvements have been done in Bug 567517 for Sirius 6.4.0.

The observed results have been described in the following blog post: https://blog.obeosoft.com/how-and-why-we-optimized-sequence-diagram-in-capella

For Sirius 6.5.0, we have detected a few location which might receive the same kind of optimization around the CombinedFragments, Operand and InteractionUse computation/layout/refresh.
Comment 1 Eclipse Genie CLA 2021-03-09 15:35:51 EST 
New Gerrit change created: https://git.eclipse.org/r/c/sirius/org.eclipse.sirius/+/177458
Comment 2 Eclipse Genie CLA 2021-03-31 16:49:51 EDT 
New Gerrit change created: https://git.eclipse.org/r/c/sirius/org.eclipse.sirius/+/178670
Comment 5 Maxime Porhel CLA 2021-04-08 08:25:11 EDT 
Steps to validate: 

- Create a Sirius sample interaction model
- Create a Sequence Diagram
- Add several items and two several combined fragments with at least three Operand in each of them.
- Resize the Operand and see that you get horizontal light_gray guides.
- Those guides are well erased when you stop the resize.
- The guides can be red when the resize is not valid.

I observed a 5% performance improvements on some use cases (less impressive than the previous steps : https://blog.obeo.fr/how-and-why-we-optimized-sequence-diagram-in-capella), but we now have Operand management code which reuse the same patterns than the executions and frames.
Comment 6 Glenn Plouhinec CLA 2021-04-23 09:13:50 EDT 
Validated with Sirius 6.5.0 IT2.
Comment 7 Glenn Plouhinec CLA 2021-04-23 09:13:50 EDT 
Validated with Sirius 6.5.0 IT2.
Comment 8 Pierre-Charles David CLA 2021-06-02 02:43:59 EDT 
Available in Sirius 6.5.0, see https://projects.eclipse.org/projects/modeling.sirius/releases/6.5.0 for details.