Community
Participate
Working Groups
Optimize layout: - org.eclipse.sirius.diagram.sequence.business.internal.layout.AbstractSequenceOrderingLayout: replace retainAll
New Gerrit change created: https://git.eclipse.org/r/c/sirius/org.eclipse.sirius/+/170167
Hi, Gerrit tests were ok with last patch from Nathalie. I have run additonal tests on our internal CI server in order to launch every full Sirius tests suites on the last patch set: - Sequence standalone tests : 70/70 - Sequence Junit tests: 68/68 - Sequence SWTBot tests: 482/482 I have also run a few tests with Nathalie's patch and an equivalent which keeps the lists results after the intersection (it keeps the Iterables.elementEquals and the for loops but there are a few additional List > LinkedHashSetSet > List transformations), tests results are on the gerrit review in favor of Nathalie's patch : Time in ms, provided patch set vs original time: Sequence Vertical Layout - Big model : 2420 vs 66500 - Internal Reproduction model : 145 vs 1030 - Simple model : 2 vs 2 Note that SequenceHorizontalLayout and SequenceObservationLayout are not impacted by the patch. Number of Sequence specific DDiagramElement - Big model: 1178 - Internal reproduction mode: 303 - Simple model: 31
The model used to test the optimization is a Capella model (1.4.0) which comes from a user and cannot be shared. It has been used as seed to construct the big and the simple Sequence diagrams and migrated to Capella 5.0.0 (dev version). The tests have been done on master branches of Capella and Sirius (Capella 5.0.0 dev preview [1] based on Sirius 6.4.0 dev preview [2]) [1] https://download.eclipse.org/capella/core/products/stable/5.0.0-S20200929-101654 [2] https://download.eclipse.org/sirius/updates/stable/6.4.0-S20200921-043506
Validation steps: - check the status of the Sequence tests (standalone, junit, swtbot) - main validation will be done on 563193.
Gerrit change https://git.eclipse.org/r/c/sirius/org.eclipse.sirius/+/170167 was merged to [master]. Commit: http://git.eclipse.org/c/sirius/org.eclipse.sirius.git/commit/?id=0f974759277c2b1a65154c68fb4fad25124f5978
New Gerrit change created: https://git.eclipse.org/r/c/sirius/org.eclipse.sirius/+/170529
New Gerrit change created: https://git.eclipse.org/r/c/sirius/org.eclipse.sirius/+/170546
New Gerrit change created: https://git.eclipse.org/r/c/sirius/org.eclipse.sirius/+/170720
New Gerrit change created: https://git.eclipse.org/r/c/sirius/org.eclipse.sirius/+/170757
New Gerrit change created: https://git.eclipse.org/r/c/sirius/org.eclipse.sirius/+/170790
New Gerrit change created: https://git.eclipse.org/r/c/sirius/org.eclipse.sirius/+/170819
New Gerrit change created: https://git.eclipse.org/r/c/sirius/org.eclipse.sirius/+/170830
New Gerrit change created: https://git.eclipse.org/r/c/sirius/org.eclipse.sirius/+/170831
New Gerrit change created: https://git.eclipse.org/r/c/sirius/org.eclipse.sirius/+/170832
New Gerrit change created: https://git.eclipse.org/r/c/sirius/org.eclipse.sirius/+/170833
New Gerrit change created: https://git.eclipse.org/r/c/sirius/org.eclipse.sirius/+/170834
New Gerrit change created: https://git.eclipse.org/r/c/sirius/org.eclipse.sirius/+/170836
New Gerrit change created: https://git.eclipse.org/r/c/sirius/org.eclipse.sirius/+/170838
New Gerrit change created: https://git.eclipse.org/r/c/sirius/org.eclipse.sirius/+/170839
New Gerrit change created: https://git.eclipse.org/r/c/sirius/org.eclipse.sirius/+/170868
New Gerrit change created: https://git.eclipse.org/r/c/sirius/org.eclipse.sirius/+/170869
New Gerrit change created: https://git.eclipse.org/r/c/sirius/org.eclipse.sirius/+/170872
New Gerrit change created: https://git.eclipse.org/r/c/sirius/org.eclipse.sirius/+/170875
New Gerrit change created: https://git.eclipse.org/r/c/sirius/org.eclipse.sirius/+/170884
New Gerrit change created: https://git.eclipse.org/r/c/sirius/org.eclipse.sirius/+/170924
New Gerrit change created: https://git.eclipse.org/r/c/sirius/org.eclipse.sirius/+/170926
New Gerrit change created: https://git.eclipse.org/r/c/sirius/org.eclipse.sirius/+/170936
New Gerrit change created: https://git.eclipse.org/r/c/sirius/org.eclipse.sirius/+/170937
New Gerrit change created: https://git.eclipse.org/r/c/sirius/org.eclipse.sirius/+/170941
New Gerrit change created: https://git.eclipse.org/r/c/sirius/org.eclipse.sirius/+/171087
New Gerrit change created: https://git.eclipse.org/r/c/sirius/org.eclipse.sirius/+/171088
New Gerrit change created: https://git.eclipse.org/r/c/sirius/org.eclipse.sirius/+/171089
New Gerrit change created: https://git.eclipse.org/r/c/sirius/org.eclipse.sirius/+/171090
New Gerrit change created: https://git.eclipse.org/r/c/sirius/org.eclipse.sirius/+/171091
New Gerrit change created: https://git.eclipse.org/r/c/sirius/org.eclipse.sirius/+/171092
New Gerrit change created: https://git.eclipse.org/r/c/sirius/org.eclipse.sirius/+/171148
New Gerrit change created: https://git.eclipse.org/r/c/sirius/org.eclipse.sirius/+/171149
New Gerrit change created: https://git.eclipse.org/r/c/sirius/org.eclipse.sirius/+/171150
New Gerrit change created: https://git.eclipse.org/r/c/sirius/org.eclipse.sirius/+/171151
New Gerrit change created: https://git.eclipse.org/r/c/sirius/org.eclipse.sirius/+/171152
New Gerrit change created: https://git.eclipse.org/r/c/sirius/org.eclipse.sirius/+/171153
Gerrit change https://git.eclipse.org/r/c/sirius/org.eclipse.sirius/+/170855 was merged to [master]. Commit: http://git.eclipse.org/c/sirius/org.eclipse.sirius.git/commit/?id=7be78fe1216966ab79926e568aa282edb39128cf
Gerrit change https://git.eclipse.org/r/c/sirius/org.eclipse.sirius/+/171148 was merged to [master]. Commit: http://git.eclipse.org/c/sirius/org.eclipse.sirius.git/commit/?id=f286d59b034bfd62ea5b3428f348ea55f6459996
Gerrit change https://git.eclipse.org/r/c/sirius/org.eclipse.sirius/+/170824 was merged to [master]. Commit: http://git.eclipse.org/c/sirius/org.eclipse.sirius.git/commit/?id=b24cc3f62319d04482377043e3f5ec0137284f6c
Gerrit change https://git.eclipse.org/r/c/sirius/org.eclipse.sirius/+/171087 was merged to [master]. Commit: http://git.eclipse.org/c/sirius/org.eclipse.sirius.git/commit/?id=0f2e443022399a9582637689103651d8678716d1
Gerrit change https://git.eclipse.org/r/c/sirius/org.eclipse.sirius/+/170834 was merged to [master]. Commit: http://git.eclipse.org/c/sirius/org.eclipse.sirius.git/commit/?id=cd99cefbb23d621090fdb4f6eea267d282477612
Gerrit change https://git.eclipse.org/r/c/sirius/org.eclipse.sirius/+/170868 was merged to [master]. Commit: http://git.eclipse.org/c/sirius/org.eclipse.sirius.git/commit/?id=ea49083b8e1c8a650c180ba8355efc87a42eb0be
Gerrit change https://git.eclipse.org/r/c/sirius/org.eclipse.sirius/+/170513 was merged to [master]. Commit: http://git.eclipse.org/c/sirius/org.eclipse.sirius.git/commit/?id=1c292c547af362379708fe9f02062833d0176508
Gerrit change https://git.eclipse.org/r/c/sirius/org.eclipse.sirius/+/170790 was merged to [master]. Commit: http://git.eclipse.org/c/sirius/org.eclipse.sirius.git/commit/?id=1c66a4c62c85fcb14ce43d3f9055537bec89e0ac
Gerrit change https://git.eclipse.org/r/c/sirius/org.eclipse.sirius/+/170875 was merged to [master]. Commit: http://git.eclipse.org/c/sirius/org.eclipse.sirius.git/commit/?id=3466ee9caf4136f41dc2988b1638dd2b9202a5d3
Gerrit change https://git.eclipse.org/r/c/sirius/org.eclipse.sirius/+/170836 was merged to [master]. Commit: http://git.eclipse.org/c/sirius/org.eclipse.sirius.git/commit/?id=13c8d6c6340071fb47ee2a554e8db627ef2e62af
Gerrit change https://git.eclipse.org/r/c/sirius/org.eclipse.sirius/+/170831 was merged to [master]. Commit: http://git.eclipse.org/c/sirius/org.eclipse.sirius.git/commit/?id=6cdbdb469a12dff87cfba17b6d44c2bccd9be725
Gerrit change https://git.eclipse.org/r/c/sirius/org.eclipse.sirius/+/170757 was merged to [master]. Commit: http://git.eclipse.org/c/sirius/org.eclipse.sirius.git/commit/?id=9cf51c4b29d4b1ae61ef34e2b986ab5928df3675
Gerrit change https://git.eclipse.org/r/c/sirius/org.eclipse.sirius/+/170546 was merged to [master]. Commit: http://git.eclipse.org/c/sirius/org.eclipse.sirius.git/commit/?id=9448482d339052367096b5dd1b1d7b4e33acac9f
Gerrit change https://git.eclipse.org/r/c/sirius/org.eclipse.sirius/+/170830 was merged to [master]. Commit: http://git.eclipse.org/c/sirius/org.eclipse.sirius.git/commit/?id=77f044e7cbd56d23b8f94525be22e9e2b006da88
Gerrit change https://git.eclipse.org/r/c/sirius/org.eclipse.sirius/+/170832 was merged to [master]. Commit: http://git.eclipse.org/c/sirius/org.eclipse.sirius.git/commit/?id=e91177f8e16b53d3345b629eefdedba0fc992452
Gerrit change https://git.eclipse.org/r/c/sirius/org.eclipse.sirius/+/170833 was merged to [master]. Commit: http://git.eclipse.org/c/sirius/org.eclipse.sirius.git/commit/?id=9a2cdd5317498a80c4338499c3a0c21eda513168
Gerrit change https://git.eclipse.org/r/c/sirius/org.eclipse.sirius/+/170872 was merged to [master]. Commit: http://git.eclipse.org/c/sirius/org.eclipse.sirius.git/commit/?id=533e2556210e2ade7e46e4d5fbf120b4c2e7b9f6
Gerrit change https://git.eclipse.org/r/c/sirius/org.eclipse.sirius/+/170839 was merged to [master]. Commit: http://git.eclipse.org/c/sirius/org.eclipse.sirius.git/commit/?id=e600958388522c67af672b4fff67bbb75d14be85
Gerrit change https://git.eclipse.org/r/c/sirius/org.eclipse.sirius/+/170869 was merged to [master]. Commit: http://git.eclipse.org/c/sirius/org.eclipse.sirius.git/commit/?id=b9df0eabea97c2aac9ec522b72ad7029bb23c6f9
Gerrit change https://git.eclipse.org/r/c/sirius/org.eclipse.sirius/+/170926 was merged to [master]. Commit: http://git.eclipse.org/c/sirius/org.eclipse.sirius.git/commit/?id=bb7d9cff5d5d7f59c50f80147bb93cbe4f8710f9
Gerrit change https://git.eclipse.org/r/c/sirius/org.eclipse.sirius/+/170838 was merged to [master]. Commit: http://git.eclipse.org/c/sirius/org.eclipse.sirius.git/commit/?id=0b606e0152a61d12e6b4ccebda5e446ac6a1f177
Gerrit change https://git.eclipse.org/r/c/sirius/org.eclipse.sirius/+/170936 was merged to [master]. Commit: http://git.eclipse.org/c/sirius/org.eclipse.sirius.git/commit/?id=c0546726c529c4ef497629a8f4829589864db3aa
Gerrit change https://git.eclipse.org/r/c/sirius/org.eclipse.sirius/+/170937 was merged to [master]. Commit: http://git.eclipse.org/c/sirius/org.eclipse.sirius.git/commit/?id=80f2c8e41c5bf681c79f993424d3e1812954ab9a
Gerrit change https://git.eclipse.org/r/c/sirius/org.eclipse.sirius/+/170924 was merged to [master]. Commit: http://git.eclipse.org/c/sirius/org.eclipse.sirius.git/commit/?id=3fab1d6c50ce90b9019b8c8cdbbb91c1ccd2881b
Gerrit change https://git.eclipse.org/r/c/sirius/org.eclipse.sirius/+/171090 was merged to [master]. Commit: http://git.eclipse.org/c/sirius/org.eclipse.sirius.git/commit/?id=b93e1893818cdee07e19a6571218b5870c8d3da3
Gerrit change https://git.eclipse.org/r/c/sirius/org.eclipse.sirius/+/171091 was merged to [master]. Commit: http://git.eclipse.org/c/sirius/org.eclipse.sirius.git/commit/?id=6795a234e72d727a8e585e5d09d7229461f797d6
Gerrit change https://git.eclipse.org/r/c/sirius/org.eclipse.sirius/+/171092 was merged to [master]. Commit: http://git.eclipse.org/c/sirius/org.eclipse.sirius.git/commit/?id=fe2dc92ae113310e2f4d0eec4bd62601ec840c8e
Gerrit change https://git.eclipse.org/r/c/sirius/org.eclipse.sirius/+/171093 was merged to [master]. Commit: http://git.eclipse.org/c/sirius/org.eclipse.sirius.git/commit/?id=e2c30158359a2464a79bc4e2f5dd808f1c26ece7
Gerrit change https://git.eclipse.org/r/c/sirius/org.eclipse.sirius/+/170941 was merged to [master]. Commit: http://git.eclipse.org/c/sirius/org.eclipse.sirius.git/commit/?id=a031b0e2ca079e9aa325b75575112056e690f01c
Gerrit change https://git.eclipse.org/r/c/sirius/org.eclipse.sirius/+/171150 was merged to [master]. Commit: http://git.eclipse.org/c/sirius/org.eclipse.sirius.git/commit/?id=b03f01a4478f82ffaf66d802446820e053ce57f4
Gerrit change https://git.eclipse.org/r/c/sirius/org.eclipse.sirius/+/171151 was merged to [master]. Commit: http://git.eclipse.org/c/sirius/org.eclipse.sirius.git/commit/?id=5f2e7764eb8f6dd5ebe5670c4be39c40ae541e8f
Gerrit change https://git.eclipse.org/r/c/sirius/org.eclipse.sirius/+/171152 was merged to [master]. Commit: http://git.eclipse.org/c/sirius/org.eclipse.sirius.git/commit/?id=e17a3820d7ebc8dadf604e1d183fb8c077ad90f1
Gerrit change https://git.eclipse.org/r/c/sirius/org.eclipse.sirius/+/171089 was merged to [master]. Commit: http://git.eclipse.org/c/sirius/org.eclipse.sirius.git/commit/?id=90189ba9383e5b76e9a510c1c99312c6d0e35893
Gerrit change https://git.eclipse.org/r/c/sirius/org.eclipse.sirius/+/171153 was merged to [master]. Commit: http://git.eclipse.org/c/sirius/org.eclipse.sirius.git/commit/?id=7c1f22a0dcd4ed1a1b4beee699a775d6ed8a7850
Gerrit change https://git.eclipse.org/r/c/sirius/org.eclipse.sirius/+/171088 was merged to [master]. Commit: http://git.eclipse.org/c/sirius/org.eclipse.sirius.git/commit/?id=c5831f39cd7dc4a3705827e1849ea4d55a9ee2e2
Gerrit change https://git.eclipse.org/r/c/sirius/org.eclipse.sirius/+/170884 was merged to [master]. Commit: http://git.eclipse.org/c/sirius/org.eclipse.sirius.git/commit/?id=b8666c1ffff78a13114d6a72fc65f83e2e506901
Gerrit change https://git.eclipse.org/r/c/sirius/org.eclipse.sirius/+/171149 was merged to [master]. Commit: http://git.eclipse.org/c/sirius/org.eclipse.sirius.git/commit/?id=c4a51f50dd49c68754d852baa50e73e4f838c15a
- 36 optimization commits have been provided on Sequence (refresh, layout, arrange, move/resize command/validation/feedback - 2 optimizations commits have been provided to Diagram (decorator computation) Junit/SWTBot from Sirius, tests from Capella has shown no regression when we applied the patches neither did the manual tests done with sample sequence diagrams made with Sirius or with the Interaction diagrams from Capella.
Validated on Sirius 6.4.0-S20201110-075607 Refresh, Sequence Layout, Move/Resize feedback, ArrangeAll have been optimized.
Available in Sirius 6.4.0, see https://download.eclipse.org/sirius/updates/releases/6.4.0/ for details.