Bug 571167 - Ctrl + enter stops working in commit dialog
Summary: Ctrl + enter stops working in commit dialog
Status: REOPENED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: IDE (show other bugs)
Version: 4.17   Edit
Hardware: PC Linux
: P3 major (vote)
Target Milestone: ---   Edit
Assignee: Project Inbox CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2021-02-12 10:52 EST by Alexander Ustimenko CLA
Modified: 2021-02-15 06:16 EST (History)
2 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Alexander Ustimenko CLA 2021-02-12 10:52:29 EST 
Eclipse Version: 2020-06 (4.16), Git integration for Eclipse 5.8.0.202006091008-r	org.eclipse.egit.feature.group	Eclipse EGit -- works.

 
Eclipse 4.17,    Git integration for Eclipse	5.9.0.202009080501-r	org.eclipse.egit.feature.group	Eclipse EGit -- not works.


Settings "Use staging view for commit" should be disabled.

Make some changes and press Ctrl + shift + 3.
Commit dialog will open.
CLick on file checkbox for stage it.
Enter commit message.
Press Ctrl + enter.
Dialog closes.

Expected (5.8): file commited.
Actual (5.9): nothing happens.
Comment 1 Alexander Ustimenko CLA 2021-02-12 11:00:10 EST 
Eclipse SDK
Version: 2020-12 (4.18)
Build id: I20201202-1800
OS: Linux, v.5.4.0-65-generic, x86_64 / gtk 3.22.30, WebKit 2.30.3
Java version: 11.0.9.1

  Git integration for Eclipse	5.8.0.202006091008-r	org.eclipse.egit.feature.group	Eclipse EGit

Also not works. So it's related to Eclipse 4.17...
Comment 2 Alexander Ustimenko CLA 2021-02-12 11:02:46 EST 
Moved to eclipse platform from egit.
Comment 3 Andrey Loskutov CLA 2021-02-12 11:56:11 EST 
Could be related to bug 570286? If so, could work in next SDK nightly build.
Comment 4 Alexander Ustimenko CLA 2021-02-12 12:09:51 EST 
(In reply to Andrey Loskutov from comment #3)
> Could be related to bug 570286? If so, could work in next SDK nightly build.

As I see now at https://download.eclipse.org/eclipse/downloads/
latest build is from 11 feb?

```
Build Name	Build Status	Build Date
I20210211-1810	Build is available Tests results are available  (4 of 4 platforms)	Thu, 11 Feb 2021 -- 18:10 (-0500)
I20210210-1800	Build is available Tests results are available  (4 of 4 platforms)	Wed, 10 Feb 2021 -- 18:00 (-0500)
I20210210-0910	Build is available Tests results are available but did not finish on all machines  (3 of 4 platforms)	Wed, 10 Feb 2021 -- 09:10 (-0500)
```

So when latest committed revert will be built -- I can download latest nightly build and all will works again?
Comment 5 Alexander Ustimenko CLA 2021-02-12 14:18:42 EST 
(In reply to Andrey Loskutov from comment #3)
> Could be related to bug 570286? If so, could work in next SDK nightly build.

Btw, dialog is closed! Just commit not happens. So may be it's not related.
Comment 6 Andrey Loskutov CLA 2021-02-15 05:44:15 EST 
Alexander, you can try https://download.eclipse.org/eclipse/downloads/drops4/I20210214-1800/ for example.
Comment 7 Alexander Ustimenko CLA 2021-02-15 06:16:35 EST 
Still not working.

I think it's not related.

Dialog is closed, but commit not happened.

If I'm switching to staging view -- all works on Ctrl+Enter as expected -- commit happens. But downside is staging view not closed.