Community
Participate
Working Groups
Hi folks, I got this problem: See the snippet: https://github.com/ingomohr/eclipse-swt-table.select-doesnt-fire-listener/blob/main/swtbug-tableselection/src/TableDefaultSelectionListener.java The listener should be notified whenever table.select is called. However, it only gets fired up when I click a TableItem with the mouse. Found this bug in Eclipse 2020-06 and in 2020-12 (didn't check 2020_09).
Not sure it's a bug, and not sure it can be changed. I see quite a lot of code in Eclipse platform that manipulates the SWT selection on a widget programmatically and the fires events explicitly, either on SWT or on JFace level. Besides, IIRC this behavior has been like that for a long time.
Hi Thomas, thanks for your feedback. If this is no bug, then isn't this rather bad design?: "You can add a selection listener here - and depending on how the seleciton changes, this might or might not notify your listener." >> "I see quite a lot of code in Eclipse platform that manipulates the SWT selection on a widget programmatically and the fires events explicitly, either on SWT or on JFace level." To me, this is quite some bug-workaround stuff imho. If select() has the problem of not fireing the added listeners, why can the select() impl not just notify the listeners itself? I normally use the JFace TableViewer, and when I set a StructuredSelection programmatically, all SelectionChangedListeners get notified. So, the current behavior is also inconsistent with JFace - and also with general listener concepts: If I have an object that can have a selection and lets clients add selectionListeners, I would expect the listeners to be fired whenever (and how-ever) the selection changes. Wouldn't you? Cheers Ingo
I stumbled over this a few times in the past. I think the use case is to modify the selection several times programmatically on SWT level, then fire the event when done. For instance, one might want to deselect everything, then select rows 3 and 4 and 7 to 9, then possibly fire an event. The javadoc of Table.addSelectionListener() says "...will be notified when the user changes the receiver's selection" ^^^^^^^^ Seems consistent with the implemented behavior.
