Bug 570641 - Remove menu-update from Workbench when keybindings change
Summary: Remove menu-update from Workbench when keybindings change
Status: NEW
Alias: None
Product: Platform
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 4.18   Edit
Hardware: PC Windows 10
: P3 normal (vote)
Target Milestone: ---   Edit
Assignee: Rolf Theunissen CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2021-01-25 14:28 EST by Rolf Theunissen CLA
Modified: 2021-09-03 06:13 EDT (History)
1 user (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Rolf Theunissen CLA 2021-01-25 14:28:01 EST 
Workbench registers a bindingManagerListener to trigger an update on the main menu when the active binding change. However, this update is already triggered in multiple places.
Comment 1 Eclipse Genie CLA 2021-01-25 14:32:27 EST 
New Gerrit change created: https://git.eclipse.org/r/c/platform/eclipse.platform.ui/+/175341
Comment 2 Rolf Theunissen CLA 2021-01-28 05:13:48 EST 
From the Gerrit review this change causes a regression, i.e. there is a interaction between menu-mnemonic and short-cuts. In fact, it practically reverses the fix for Bug 65775.
As suggested in that Bug, it might be more efficient to move the listener to keybindings inside the MenuManager.

My main concern with the current implementation was that the menumanager in the Workbench must be initialized very early (no lazy initialization), while I like to initialize it after the menu-renders are initialized.

Also note that there are still issues with the the disabling of menu-mnemonics, the remainder of Bug 208626 for toplevel menus.