Bug 570274 - [win32] No more handles with I20210111-1800
Summary: [win32] No more handles with I20210111-1800
Status: VERIFIED FIXED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: SWT (show other bugs)
Version: 4.19   Edit
Hardware: PC Windows 10
: P3 blocker (vote)
Target Milestone: 4.19 M3   Edit
Assignee: Nikita Nemkin CLA
QA Contact:
URL:
Whiteboard:
Keywords: regression
Depends on:
Blocks:
 
Reported: 2021-01-12 02:56 EST by Clemens Wyss CLA
Modified: 2021-02-17 05:52 EST (History)
5 users (show)

See Also:


Attachments
log (7.00 KB, text/plain)
2021-01-12 03:09 EST, Clemens Wyss CLA
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Clemens Wyss CLA 2021-01-12 02:56:17 EST
As of updating to the newest integration build of 4.19 (I guess I20210111-1800) I am getting "Unhandled event loop exception No more handles" on almost all menu selections
Comment 1 Andrey Loskutov CLA 2021-01-12 03:04:57 EST
Please attach error logs
Comment 2 Clemens Wyss CLA 2021-01-12 03:09:24 EST
Created attachment 285258 [details]
log

Sorry for omitting this/these
Comment 3 Clemens Wyss CLA 2021-01-12 03:23:01 EST
Is there any possibility to temporarily revert back to I_build I20210110-1800 ?
Comment 4 Andrey Loskutov CLA 2021-01-12 03:26:27 EST
Not sure what did you have updated and how (the SWT stack trace doesn't match current SWT code, so it is NOT from I20210111-1800). I guess your installation is corrupt and contains wrong set of bundles.

I'm running I20210111-1800 (installed from scratch) without issues on (Linux).
Comment 5 Clemens Wyss CLA 2021-01-12 03:33:42 EST
"Normal" Update from https://download.eclipse.org/eclipse/updates/4.19-I-builds/
I updated "all that was listed to be updated". Don't have the exact list at hand though. But I am pretty sure that I was coming from 4.19.0.I20210110-1800, so it must be something with 4.19.0.I20210111-1800

Also: in the log I see
eclipse.buildId=4.19.0.I20210111-1800
Comment 6 Rolf Theunissen CLA 2021-01-12 04:26:43 EST
I can confirm that I see the same behavior, on 4.19.0.I20210111-1800, just upgraded with Oomph.

3.116.0.v20210111-2309	org.eclipse.swt.win32.win32.x86_64

Recent JNI changes might have caused this issue
Comment 7 Rolf Theunissen CLA 2021-01-12 04:35:52 EST
It might be that the exception pops up for ever org.eclipse.swt.widgets.Group.createHandle call.
Comment 8 Nikita Nemkin CLA 2021-01-12 04:37:15 EST
I'm looking into it.
Comment 9 Nikita Nemkin CLA 2021-01-12 05:53:31 EST
I can't reproduce it even after updating my work configuration to I20210111-1800.

Please try the vanilla SDK I-build:
https://download.eclipse.org/eclipse/downloads/drops4/I20210111-1800/download.php?dropFile=eclipse-SDK-I20210111-1800-win32-x86_64.zip
and see if it has the problem.

Also, please share your Eclipse configuration (Installation Details -> Configuration, mind the private info in environment variables).
Comment 10 Rolf Theunissen CLA 2021-01-12 06:06:41 EST
Same issue with the vanilla SDK I-build.

Windows version: 1909 (OS Build 18363.1256)
Comment 11 Rolf Theunissen CLA 2021-01-12 06:13:18 EST
I can even reproduce it with Snippet112, Snippet214, Snippet366
Comment 12 Nikita Nemkin CLA 2021-01-12 06:30:56 EST
(In reply to Rolf Theunissen from comment #11)
> I can even reproduce it with Snippet112, Snippet214, Snippet366

Thank you, it's helpful to know that the rest of Eclipse isn't involved.
Let's see if AppVerifier finds the problem.
Comment 13 Eclipse Genie CLA 2021-01-12 07:13:26 EST
New Gerrit change created: https://git.eclipse.org/r/c/platform/eclipse.platform.swt/+/174692
Comment 15 Nikita Nemkin CLA 2021-01-12 07:30:51 EST
Should be fixed now. The problem involved uninitialized stack reads, hence the trouble with reproducing it.

Waiting for the next I-build to verify.
Comment 16 Niraj Modi CLA 2021-01-12 09:05:10 EST
(In reply to Nikita Nemkin from comment #15)
> Should be fixed now. The problem involved uninitialized stack reads, hence
> the trouble with reproducing it.
> 
> Waiting for the next I-build to verify.

Thanks Nikita for taking care of this issue.
Marked current IBuild I20210111-1800 as Unstable!

Triggered a new IBuild for verification.
Comment 17 Clemens Wyss CLA 2021-01-13 00:34:46 EST
the new integration build seems to fix the issue. Thx for solving sooo fast!

Note:
My installation running on the "malicious I-build" could NOT update to the new I-build
Comment 18 Niraj Modi CLA 2021-01-13 01:16:00 EST
(In reply to Clemens Wyss from comment #17)
> the new integration build seems to fix the issue. Thx for solving sooo fast!
> 

Thanks for the verification and confirmation, resolving now.
Comment 19 Niraj Modi CLA 2021-02-17 05:52:42 EST
(In reply to Niraj Modi from comment #18)
> (In reply to Clemens Wyss from comment #17)
> > the new integration build seems to fix the issue. Thx for solving sooo fast!
> > 
> 
> Thanks for the verification and confirmation, resolving now.

Marking as verified.