Bug 568835 - Background for 'always show at startup' on macOS has wrong background
Summary: Background for 'always show at startup' on macOS has wrong background
Status: RESOLVED FIXED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 4.18   Edit
Hardware: PC Mac OS X
: P3 minor (vote)
Target Milestone: 4.19 M3   Edit
Assignee: Matthias Becker CLA
QA Contact:
URL:
Whiteboard:
Keywords: usability
Depends on:
Blocks: 569282
  Show dependency tree
 
Reported: 2020-11-16 04:17 EST by Alex Blewitt CLA
Modified: 2021-01-08 07:00 EST (History)
2 users (show)

See Also:

Attachments
Screenshot showing bug (206.34 KB, image/png)
2020-11-16 04:17 EST, Alex Blewitt CLA 		no flags Details
Scrrenshot showing the fixed issue (364.90 KB, image/png)
2020-11-17 08:37 EST, Matthias Becker CLA 		no flags Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Alex Blewitt CLA 2020-11-16 04:17:01 EST 
Created attachment 284771 [details]
Screenshot showing bug

When Eclipse is set to the dark theme, when launching the welcome screen the 'always show welcome at startup' is shown with a white background

Version: 2020-12 M2 (4.18.0 M2)
Build id: 20201105-1505
Comment 1 Lars Vogel CLA 2020-11-16 05:36:48 EST 
Matthias, didn't you fix that recently?
Comment 2 Matthias Becker CLA 2020-11-16 05:49:41 EST 
(In reply to Lars Vogel from comment #1)
> Matthias, didn't you fix that recently?

I am not aware of this. I will look into this.
Comment 3 Eclipse Genie CLA 2020-11-17 08:34:08 EST 
New Gerrit change created: https://git.eclipse.org/r/c/platform/eclipse.platform.ua/+/172373
Comment 4 Matthias Becker CLA 2020-11-17 08:37:04 EST 
Created attachment 284787 [details]
Scrrenshot showing the fixed issue
Comment 5 Matthias Becker CLA 2020-11-17 08:37:57 EST 
(In reply to Eclipse Genie from comment #3)
> New Gerrit change created:
> https://git.eclipse.org/r/c/platform/eclipse.platform.ua/+/172373

I would propose we merge this early 4.19. Changes to the css files may have unintended side effects.
Comment 6 Alexander Kurtakov CLA 2021-01-07 03:07:52 EST 
Mass move 4.19 M1 bugs to M3