Bug 568543 - Project Explorer and Package Explorer tree view selection unreadable
Summary: Project Explorer and Package Explorer tree view selection unreadable
Status: NEW
Alias: None
Product: Platform
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 4.17   Edit
Hardware: PC Windows 7
: P3 major (vote)
Target Milestone: ---   Edit
Assignee: Platform-UI-Inbox CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2020-11-04 20:17 EST by Exuvo _ CLA
Modified: 2020-11-08 21:03 EST (History)
1 user (show)

See Also:


Attachments
With built in dark theme (1.33 KB, image/png)
2020-11-04 20:17 EST, Exuvo _ CLA
no flags Details
With darkest dark theme addon (1.37 KB, image/png)
2020-11-04 20:17 EST, Exuvo _ CLA
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Exuvo _ CLA 2020-11-04 20:17:18 EST
Created attachment 284673 [details]
With built in dark theme

Just installed new eclipse 2020-09 (4.17.0) and with dark mode the project tree views are unusable. The arrows are black on black, the selected item is white on white or white on light blue, both unreadable.

Found no apperance setting to fix the selection color.
Tried marketplace addon Darkest Dark Theme and that had the same problem (i use that one in my older eclipse 2019-09 which has no problems).

Found a stackoverflow post with the same problem https://stackoverflow.com/questions/62872324/change-color-of-bullet-in-tree-view-in-eclipse and they say it started with eclipse 2020-06.
Comment 1 Exuvo _ CLA 2020-11-04 20:17:46 EST
Created attachment 284674 [details]
With darkest dark theme addon
Comment 2 Andrew Obuchowicz CLA 2020-11-05 01:29:19 EST
IIRC there was a workaround fix for this bug on Windows 7 which has since been removed, since it does not occur on Windows 10 (and Eclipse is not supported on Windows 7 anymore I believe). I might be wrong however, and would appreciate if someone can confirm this.
Comment 3 Andrew Obuchowicz CLA 2020-11-05 01:31:53 EST
There's some relevant discussion on this issue here: https://github.com/AObuchow/Eclipse-Spectrum-Theme/issues/123
as a Spectrum Theme user had encountered the same issue.
Comment 4 Exuvo _ CLA 2020-11-05 10:55:22 EST
I cannot see any texts about supported windows versions on the eclipse download pages https://www.eclipse.org/downloads/packages/ or the installation guide https://wiki.eclipse.org/Eclipse/Installation, where does it say that?

If win7 is dropped then I suggest adding a warning popup when trying to select the dark theme on windows 7 then to say "OS no longer supported, last working version is 2020-03".

Do i understand correctly that the new eclipse requires you to use a dark OS theme if you want to use the dark theme in eclipse?
Comment 5 Andrew Obuchowicz CLA 2020-11-08 21:03:02 EST
(In reply to Exuvo _ from comment #4)
> I cannot see any texts about supported windows versions on the eclipse
> download pages https://www.eclipse.org/downloads/packages/ or the
> installation guide https://wiki.eclipse.org/Eclipse/Installation, where does
> it say that?

I personally haven't been able to find an official statement that Eclipse is no longer supported for Windows 7 (although I just checked briefly).
However, I can confirm that Windows 7 is no longer officially supported by Microsoft: https://support.microsoft.com/en-us/windows/what-happens-when-windows-7-support-ends-5c740944-b787-a89e-ad23-69ec848ae763#:~:text=After%2010%20years%2C%20support%20for,including%20security%20updates%2C%20from%20Microsoft.

Thus, it seems Eclipse on Windows 7 is transitively not supported. 

> 
> If win7 is dropped then I suggest adding a warning popup when trying to
> select the dark theme on windows 7 then to say "OS no longer supported, last
> working version is 2020-03".

Agreed, or perhaps in general a popup (that can be disabled) should appear upon launching Eclipse on Windows 7 informing the user that it is no longer supported.
However, I think updating the Eclipse download page or the installation wiki to note about lack of windows 7 support would be a better fix.


> Do i understand correctly that the new eclipse requires you to use a dark OS
> theme if you want to use the dark theme in eclipse?

I don't think this is the case although I haven't tested it personally (I use a dark theme on Windows 10, but I use Linux as my primary OS). From what I understand, there was a limitation in Windows 7 that prevented the toggle arrows from appearing white when using the dark theme, thus a workaround was made. These workarounds have now since been removed.

Again, if someone wants to add some extra info it would be appreciated - I'm not the most knowledgable about support for Eclipse on Windows.