Bug 568438 - remove code quality checks from the designer that are already present in Titanium
Summary: remove code quality checks from the designer that are already present in Tita...
Status: NEW
Alias: None
Product: z_Archived
Classification: Eclipse Foundation
Component: titan.plugins (show other bugs)
Version: unspecified   Edit
Hardware: PC Windows 10
: P3 enhancement (vote)
Target Milestone: ---   Edit
Assignee: Project Inbox CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2020-11-02 06:33 EST by Kristof Szabados CLA
Modified: 2021-04-23 11:10 EDT (History)
0 users

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Kristof Szabados CLA 2020-11-02 06:33:51 EST
When Titanium was not yet present, the first code quality checks were added to the Designer plugin (Window/ Preferences / TITAN Preferences/ On-the-fly checker/ Errors/Warnings).

When Titanium was first added these old checks were left in place, so that users not yet familiar with Titanium could still access them.

By now, it would be better if these checks would be removed from the Designer, to exist only in Titanium:
- there would be no double implementation of the same check.
- Titanium's architecture is better suited for this kind of work, thanks to it's visitor based logic.
- Removing these checkers from the Designer would make its code less complex and semantic checks faster.
Comment 1 Kristof Szabados CLA 2020-12-07 11:40:03 EST
Most of the checks that were available in both the Designer and Titanium are now only available in Titanium for the users.

But Definition.referingHere and Assignment.isused in the Designer could not yet be removed as functionality in Titanium depends on them.
This dependence should be cut, and the needed functionality implemented purely in Titanium, so that these elements could be removed too.
Comment 2 Denis Roy CLA 2021-04-23 11:10:21 EDT
This bug was migrated to GitLab: https://gitlab.eclipse.org/eclipse/titan/titan.EclipsePlug-ins/-/issues