Bug 568311 - Parallel build doesn't consider rebuildRequested flag
Summary: Parallel build doesn't consider rebuildRequested flag
Status: NEW
Alias: None
Product: Platform
Classification: Eclipse Project
Component: Resources (show other bugs)
Version: 4.8   Edit
Hardware: All All
: P3 normal (vote)
Target Milestone: ---   Edit
Assignee: Platform-Resources-Inbox CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: 527212
  Show dependency tree
 
Reported: 2020-10-27 13:05 EDT by Andrey Loskutov CLA
Modified: 2020-10-28 04:56 EDT (History)
1 user (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Andrey Loskutov CLA 2020-10-27 13:05:27 EDT 
While working on bug 568299 I've noticed, that BuildManager.rebuildRequested flag is not used by parallelBuildLoop() introduced via bug 530649.

That means, if the builder requests a rebuild during a parallel build, nothing will happen, and most likely the result would be not the one that would be during sequential build.

Historically rebuildRequested flag was added to resolve build cycles in JDT (so the sequential build also considers IWorkspaceDescription.getMaxBuildIterations()), but we are also use it in our application to re-trigger the build cycle if we detect and fix some project configuration issues (wrong JDT settings etc).

So for me looks like BuildManager.parallelBuildLoop() should consider both rebuildRequested & getMaxBuildIterations() to produce same results as the sequential build.

I have not searched explicitly for related bugs, but bugzilla offered me bug 510389 as a possible candidate that could be related.