Bug 568251 - [GTK] Memory corruption in Display.initializeSystemSettings
Summary: [GTK] Memory corruption in Display.initializeSystemSettings
Status: RESOLVED FIXED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: SWT (show other bugs)
Version: 4.18   Edit
Hardware: PC Linux
: P3 major (vote)
Target Milestone: 4.18 M3   Edit
Assignee: Alexandr Miloslavskiy CLA
QA Contact:
URL:
Whiteboard:
Keywords: regression
: 568497 (view as bug list)
Depends on:
Blocks:
 
Reported: 2020-10-26 09:49 EDT by Alexandr Miloslavskiy CLA
Modified: 2020-11-06 01:17 EST (History)
3 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Alexandr Miloslavskiy CLA 2020-10-26 09:49:16 EDT 
Running SWT with '-Xcheck:jni' reveals the following error:

FATAL ERROR in native method: ReleasePrimitiveArrayCritical: failed bounds check
  at org.eclipse.swt.internal.gtk.OS.g_object_get(Native Method)
  at org.eclipse.swt.widgets.Display.initializeSystemSettings(Display.java:3766)
  at org.eclipse.swt.widgets.Display.init(Display.java:3420)
  <...>

This is a regression from Bug 566017. I will share a patch soon.
Comment 1 Eclipse Genie CLA 2020-10-26 10:14:42 EDT 
New Gerrit change created: https://git.eclipse.org/r/c/platform/eclipse.platform.swt/+/171301
Comment 2 Eclipse Genie CLA 2020-10-26 10:33:10 EDT 
New Gerrit change created: https://git.eclipse.org/r/c/platform/eclipse.platform.swt/+/171302
Comment 4 Andrey Loskutov CLA 2020-10-28 04:03:25 EDT 
(In reply to Eclipse Genie from comment #3)
> Gerrit change
> https://git.eclipse.org/r/c/platform/eclipse.platform.swt/+/171301 was
> merged to [master].
> Commit:
> http://git.eclipse.org/c/platform/eclipse.platform.swt.git/commit/
> ?id=751345e1fdaedad7e68ad26bf63324ecfc7ece43

I can verify that the crash with -Xcheck:jni can't be observed with I20201028-0130 anymore. Thanks Alexandr!

Not closing yet, we still have another patch to merge (https://git.eclipse.org/r/c/platform/eclipse.platform.swt/+/171302).
Comment 5 Andrey Loskutov CLA 2020-11-03 10:23:17 EST 
*** Bug 568497 has been marked as a duplicate of this bug. ***
Comment 7 Andrey Loskutov CLA 2020-11-06 01:17:01 EST 
Thanks Alexandr!