Bug 568243 - CodeMinings are never disposed
Summary: CodeMinings are never disposed
Status: NEW
Alias: None
Product: Platform
Classification: Eclipse Project
Component: Text (show other bugs)
Version: 4.18   Edit
Hardware: PC Linux
: P3 normal (vote)
Target Milestone: ---   Edit
Assignee: Platform-UI-Inbox CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2020-10-26 06:20 EDT by Julien HENRY CLA
Modified: 2020-10-26 20:03 EDT (History)
1 user (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Julien HENRY CLA 2020-10-26 06:20:48 EDT 
I have started to implement a code mining, and I noticed that the dispose method is never called.

For example you can put a breakpoint here: https://github.com/angelozerr/jdt-codemining/blob/137822bf77451b51d717e5565eac19d0fffd5ac0/org.eclipse.jdt.codemining/src/org/eclipse/debug/ui/codemining/provisional/AbstractDebugVariableCodeMiningProvider.java#L99

The code mining provider is instanciated here:
https://github.com/eclipse/eclipse.platform.text/blob/6c75d96e39e7421210e1a47a787ded7c1b99e539/org.eclipse.ui.workbench.texteditor/src/org/eclipse/ui/texteditor/AbstractTextEditor.java#L4024
and then stored on the source viewer.

But then when the code viewer is closed, the dispose method of the ICodeMiningProvider is never called.