Bug 568223 - Update the macOS archive names
Summary: Update the macOS archive names
Status: NEW
Alias: None
Product: Platform
Classification: Eclipse Project
Component: Releng (show other bugs)
Version: 4.21   Edit
Hardware: PC Mac OS X
: P3 normal (vote)
Target Milestone: ---   Edit
Assignee: Platform-Releng-Inbox CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2020-10-25 14:36 EDT by Liviu Ionescu CLA
Modified: 2021-05-06 22:50 EDT (History)
2 users (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Liviu Ionescu CLA 2020-10-25 14:36:23 EDT
The current macOS archive names look like:

- eclipse-embedcpp-2020-12-M1-macosx-cocoa-x86_64.dmg

Given that Apple no longer uses 'Mac OS X' but 'macOS', and the future version will be arabic 11, not latin X or XI, I suggest we update the archive names to something like:

- eclipse-embedcpp-2020-12-M1-macos-cocoa-x86_64.dmg

The 'cocoa' name as the graphical interface is (still) ok, we'll re-evaluate after the new machines using Apple Silicon will be out.
Comment 1 Liviu Ionescu CLA 2020-10-28 12:12:46 EDT
I took a look at the EPP sources and tried to identify where the name of the archive comes from.

It is defined as:

<product>
  <id>${project.artifactId}</id>
  <rootFolder>eclipse</rootFolder>
  <rootFolders>
    <macosx>Eclipse.app</macosx>
  </rootFolders>
  <archiveFileName>${build}_eclipse-${eclipse.epp.id}-${eclipse.simultaneous.release.id}</archiveFileName>
</product>

So the 'macos-cocoa-x86_64' part comes as '${eclipse.simultaneous.release.id}'.

Unfortunately my knowledge of SimRel is not enough to suggest a solution. :-(

If this requires another issue in SimRel, please fell free to add it.
Comment 2 Jonah Graham CLA 2020-11-05 10:49:03 EST
It would be possible to rename the .dmg/.tar.gz at the last step (sort of how we change . to - in the names). However that would make EPP inconsistent with SDK and that makes me a little uncomfortable.


> So the 'macos-cocoa-x86_64' part comes as
> '${eclipse.simultaneous.release.id}'.

The .macosx. in the name does not come from eclipse.simultaneous.release.id. that id is "2012-12-M2". The archiveFileName is appended with the target triplet by tycho. The target triplet comes from the <environments> section in the pom.xml. However you can only define an environment triplet that has a matching org.eclipse.equinox.launcher plug-in. So you can't change the macosx one to macos because there is no  org.eclipse.equinox.launcher.cocoa.macos.x86_64 bundle, the bundle is  org.eclipse.equinox.launcher.cocoa.macosx.x86_64.

So I don't know how or when this name should change, but I don't think I am going to lead it.
Comment 3 Jonah Graham CLA 2021-05-06 22:50:01 EDT
If Platform change the names of the packages (and I suppose the keys for OS?) then EPP will follow suit. So this bug belongs with Platform for their consideration.