Bug 567848 - Keybindings are kicked out by the model assembler
Summary: Keybindings are kicked out by the model assembler
Status: NEW
Alias: None
Product: Platform
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 4.18   Edit
Hardware: PC Windows 10
: P3 normal (vote)
Target Milestone: ---   Edit
Assignee: Platform-UI-Inbox CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: 552208
  Show dependency tree
 
Reported: 2020-10-13 14:58 EDT by Wim Jongman CLA
Modified: 2020-10-14 11:43 EDT (History)
0 users

See Also:

Attachments
Application model vs Runtime model (211.01 KB, image/png)
2020-10-13 14:58 EDT, Wim Jongman CLA 		no flags Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Wim Jongman CLA 2020-10-13 14:58:24 EDT 
Created attachment 284441 [details]
Application model vs Runtime model

I can't get my keybindings to work in a simple e4 application. 

Adding the model spy, showed that my keybindings were not in the model.

I debugged the ModelAssembler process and found code that it explicitly removed all keybindings in the model that were not tagged "type:user" [1]

This was introduced by bug 406003 [1].

The keybindings should not be silently dropped.


[2] https://git.eclipse.org/c/platform/eclipse.platform.ui.git/commit/?id=953285631d9aa17b85009ec67ebeda1e06f5ea33
Comment 1 Wim Jongman CLA 2020-10-14 09:22:05 EDT 
(In reply to Wim Jongman from comment #0)

> 
> 
> [2]
> https://git.eclipse.org/c/platform/eclipse.platform.ui.git/commit/
> ?id=953285631d9aa17b85009ec67ebeda1e06f5ea33

Darn, I linked the wrong patch. Sorry for the spam. It's here [1].

The idea of bug 406003 seems logical, but it is broken in some cases. I will try to figure out what is wrong with it. With PW gone, I assume we no longer have experts in this area. 


https://git.eclipse.org/c/platform/eclipse.platform.ui.git/commit/?id=cc298fea671240a16fe977aa8ee2b70274de70d5