Community
Participate
Working Groups
Created attachment 284385 [details] properly auto-generated disabled icons in the menu vs toolbar My plugin has a toolbar with a bunch of commands. Before updating to 4.17 their icons became disabled (low-contrast) when the command is disabled (has no handler/whatever). I relied on this and never provided separate disabled icons for my commands. In 4.17 toolbar buttons render the base icons regardless of the command state. But in a menu, the icons correctly render their Eclipse-generated disabled version as expected. See attached screenshot for menu (old behaviour)/toolbar comparison.
What is the last working Eclipse version for you? Can you provide a minimal working snippet to reproduce? This reminds me somehow on bug 563407. Please also attach your GTK version if this is a Linux only issue.
Created attachment 284386 [details] repro project I made a quick repro with 2 commands and handlers, one disabled by the lack of handler impl class, another disabled explicitly by an enabledWhen rule. Both are added into a menu and a toolbar, and both reproduce the issue. I checked on Windows and this is indeed a Linux only issue. GTK version is 3.24.20.
Forgot to mention, this only broke in the last release (4.17), was working fine until the update.
(In reply to Alexander Levsha from comment #3) > Forgot to mention, this only broke in the last release (4.17), was working > fine until the update. Both icons in the toolbar & menu look disabled for me on 4.18 head (GTK 3.22). Can you please try with latest I build?
Yep, in I20201007-0600 it works for me as well, both in the repro case and with my main plugin. So i guess it's only broken in 4.17.
Alexander, it would be great if you could bisect this to the right commit that broke 4.17 and for bonus points to the commit that fixed this in 4.18.
I'm afraid that would be outside my area of expertise. I never managed to make my eclipse source workspace error-free, let alone run it from source.
