Bug 567424 - Resolve discouraged access for org.eclipse.e4.core.commands on package org.eclipse.e4.core.services.log
Summary: Resolve discouraged access for org.eclipse.e4.core.commands on package org.ec...
Status: NEW
Alias: None
Product: Platform
Classification: Eclipse Project
Component: Runtime (show other bugs)
Version: 4.18   Edit
Hardware: All All
: P3 minor (vote)
Target Milestone: ---   Edit
Assignee: platform-runtime-inbox CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2020-09-28 18:08 EDT by Karsten Thoms CLA
Modified: 2020-10-01 01:10 EDT (History)
0 users

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Karsten Thoms CLA 2020-09-28 18:08:01 EDT 
Class org.eclipse.e4.core.commands.internal.HandlerServiceImpl is using restricted API org.eclipse.e4.core.services.log.Logger, which raises build warnings.

The bundle org.eclipse.e4.core.commands should be added to x-friends of the exported package.


22:41:06 [INFO] --- tycho-compiler-plugin:2.0.0:compile (default-compile) @ org.eclipse.e4.core.commands ---
22:41:06 [INFO] Compiling 11 source files to /home/jenkins/agent/workspace/eclipse.platform.ui-Gerrit/bundles/org.eclipse.e4.core.commands/target/classes
22:41:06 [WARNING] /home/jenkins/agent/workspace/eclipse.platform.ui-Gerrit/bundles/org.eclipse.e4.core.commands/src/org/eclipse/e4/core/commands/internal/HandlerServiceImpl.java:[37] 
22:41:06 	import org.eclipse.e4.core.services.log.Logger;
22:41:06 	       ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
22:41:06 Discouraged access: The type 'Logger' is not API (restriction on classpath entry '/home/jenkins/agent/workspace/eclipse.platform.ui-Gerrit/.repository/p2/osgi/bundle/org.eclipse.e4.core.services/2.2.500.v20200922-2207/org.eclipse.e4.core.services-2.2.500.v20200922-2207.jar')
22:41:06 [WARNING] /home/jenkins/agent/workspace/eclipse.platform.ui-Gerrit/bundles/org.eclipse.e4.core.commands/src/org/eclipse/e4/core/commands/internal/HandlerServiceImpl.java:[154] 
22:41:06 	Logger logger;
22:41:06 	^^^^^^
22:41:06 Discouraged access: The type 'Logger' is not API (restriction on classpath entry '/home/jenkins/agent/workspace/eclipse.platform.ui-Gerrit/.repository/p2/osgi/bundle/org.eclipse.e4.core.services/2.2.500.v20200922-2207/org.eclipse.e4.core.services-2.2.500.v20200922-2207.jar')
22:41:06 [WARNING] /home/jenkins/agent/workspace/eclipse.platform.ui-Gerrit/bundles/org.eclipse.e4.core.commands/src/org/eclipse/e4/core/commands/internal/HandlerServiceImpl.java:[200] 
22:41:06 	logger.error((Throwable) obj, "Command '" + command.getId() + "' failed"); //$NON-NLS-1$ //$NON-NLS-2$
22:41:06 	       ^^^^^
22:41:06 Discouraged access: The method 'Logger.error(Throwable, String)' is not API (restriction on classpath entry '/home/jenkins/agent/workspace/eclipse.platform.ui-Gerrit/.repository/p2/osgi/bundle/org.eclipse.e4.core.services/2.2.500.v20200922-2207/org.eclipse.e4.core.services-2.2.500.v20200922-2207.jar')
22:41:06 3 problems (3 warnings)
Comment 1 Eclipse Genie CLA 2020-09-28 18:14:08 EDT 
New Gerrit change created: https://git.eclipse.org/r/c/platform/eclipse.platform.runtime/+/169997