Bug 566549 - Avoid hard code dark colors in the dark theme and find better colors
Summary: Avoid hard code dark colors in the dark theme and find better colors
Status: RESOLVED FIXED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 4.14   Edit
Hardware: PC Linux
: P3 normal (vote)
Target Milestone: 4.18 M3   Edit
Assignee: Lars Vogel CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: 566539
  Show dependency tree
 
Reported: 2020-09-01 08:17 EDT by Lars Vogel CLA
Modified: 2020-11-30 04:50 EST (History)
5 users (show)

See Also:

Attachments
SmartGit screenshot (51.01 KB, image/png)
2020-09-01 08:23 EDT, Alexandr Miloslavskiy CLA 		no flags Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Lars Vogel CLA 2020-09-01 08:17:44 EDT 
Currently most of the dark colors are hard-coded. 

We should move them to use color definitions so that users can customize them. In this process we should also simplify our colors and potentially improve the selected colors, e.g. by looking at other tools like VsCode.
Comment 1 Lars Vogel CLA 2020-09-01 08:18:02 EDT 
Might also help with Bug 564960.
Comment 2 Lars Vogel CLA 2020-09-01 08:18:59 EDT 
Alexandr, IIRC you also suggested the usage of better dark colors for the IDE.
Comment 3 Alexandr Miloslavskiy CLA 2020-09-01 08:23:40 EDT 
Created attachment 284007 [details]
SmartGit screenshot

I think I was saying that in our product, we're using different colors.
Comment 4 Lars Vogel CLA 2020-09-02 08:04:22 EDT 
(In reply to Alexandr Miloslavskiy from comment #3)
> Created attachment 284007 [details]
> SmartGit screenshot
> 
> I think I was saying that in our product, we're using different colors.

Looks great. 

Btw. why is your shell header (the part where the white icon and the Preference text is located) also dark? I though this is not yet supported by Win SWT.
Comment 5 Alexandr Miloslavskiy CLA 2020-09-02 08:07:20 EDT 
It is indeed not supported by SWT yet. Unfortunately the patch is too hackish. 

We're whitelisting specific Windows versions to stay safe. This means that older code running on newer Windows will not have the dark header.
Comment 6 Lars Vogel CLA 2020-09-11 07:33:50 EDT 
Amit, are you also interested in the dark theme? If yes, could you help moving the hard-coded colors to color definitions which the user can adjust?
Comment 7 Amit Mendapara CLA 2020-09-11 08:00:13 EDT 
(In reply to Lars Vogel from comment #6)
> Amit, are you also interested in the dark theme? If yes, could you help
> moving the hard-coded colors to color definitions which the user can adjust?

Yes, I can help with GTK theme.
Comment 8 Lars Vogel CLA 2020-09-11 09:49:21 EDT 
(In reply to Amit Mendapara from comment #7)
> (In reply to Lars Vogel from comment #6)
> > Amit, are you also interested in the dark theme? If yes, could you help
> > moving the hard-coded colors to color definitions which the user can adjust?
> 
> Yes, I can help with GTK theme.

Cool. Please start providing Gerrits.
Comment 9 Eclipse Genie CLA 2020-10-05 05:18:10 EDT 
New Gerrit change created: https://git.eclipse.org/r/c/platform/eclipse.platform.ui/+/170306
Comment 10 Eclipse Genie CLA 2020-10-05 05:37:31 EDT 
New Gerrit change created: https://git.eclipse.org/r/c/platform/eclipse.platform.ui/+/170308
Comment 11 Eclipse Genie CLA 2020-10-05 05:43:22 EDT 
New Gerrit change created: https://git.eclipse.org/r/c/platform/eclipse.platform.ui/+/170311
Comment 12 Eclipse Genie CLA 2020-10-05 05:55:30 EDT 
New Gerrit change created: https://git.eclipse.org/r/c/platform/eclipse.platform.ui/+/170313
Comment 14 Lars Vogel CLA 2020-11-18 08:31:57 EST 
Mass change to 4.19 M1, please update the target if you have other plans.
Comment 15 Lars Vogel CLA 2020-11-30 04:50:34 EST 
At least some colors can now be configured by the user.