Bug 566269 - [Win32][Dark theme] Check boxes light in the dark theme
Summary: [Win32][Dark theme] Check boxes light in the dark theme
Status: RESOLVED FIXED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: SWT (show other bugs)
Version: 4.16   Edit
Hardware: PC Windows 10
: P3 normal (vote)
Target Milestone: ---   Edit
Assignee: Platform-SWT-Inbox CLA
QA Contact:
URL:
Whiteboard:
Keywords: helpwanted
Depends on:
Blocks: 577357
  Show dependency tree
 
Reported: 2020-08-21 10:09 EDT by Lars Vogel CLA
Modified: 2022-11-25 04:44 EST (History)
4 users (show)

See Also:


Attachments
Screenshot (7.47 KB, image/png)
2020-08-21 10:09 EDT, Lars Vogel CLA
no flags Details
SWT Controls - checkboxes - ubuntu 20.04 vs win10 vs win11_22621.PNG (282.82 KB, image/png)
2022-11-21 18:21 EST, John Moule CLA
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Lars Vogel CLA 2020-08-21 10:09:26 EDT
Created attachment 283933 [details]
Screenshot

While we were joking in Bug 563473 that some light is nice in these dark times, it actually would be nice, if checkbox buttons are also darker.
Comment 1 Alexandr Miloslavskiy CLA 2020-08-21 11:02:27 EDT
Windows 10 doesn't provide any support for Dark Theme checkbox yet. I don't think that we can easily draw it on our own and still keep various small neat details such as mouse hover animation.

I think that the problem is very marginal and not worthy of further effort. Hopefully Win10 will just provide the theme at some point.
Comment 2 Niraj Modi CLA 2022-03-02 05:14:15 EST
(In reply to Alexandr Miloslavskiy from comment #1)
> Windows 10 doesn't provide any support for Dark Theme checkbox yet. I don't
> think that we can easily draw it on our own and still keep various small
> neat details such as mouse hover animation.
> 
> I think that the problem is very marginal and not worthy of further effort.
> Hopefully Win10 will just provide the theme at some point.

Quick check: Does Win10/Win11 support this now ?
Comment 3 Alexandr Miloslavskiy CLA 2022-03-06 11:02:50 EST
As of Win11 version 22000.527, there is still no support for dark checkbox in native theme package (file 'aero.msstyles').
Comment 4 Alexandr Miloslavskiy CLA 2022-03-06 11:06:33 EST Comment hidden (obsolete)
Comment 5 John Moule CLA 2022-11-21 18:21:03 EST
Created attachment 288850 [details]
SWT Controls - checkboxes - ubuntu 20.04 vs win10 vs win11_22621.PNG

Screengrab shows how Checkbox button controls look across different platforms in dark mode:
ubuntu 20.04 vs win10 vs win11_22621
Ubuntu on LHS and Win11 on RHS.
Comment 6 John Moule CLA 2022-11-21 18:22:26 EST
(In reply to Alexandr Miloslavskiy from comment #3)
> As of Win11 version 22000.527, there is still no support for dark checkbox
> in native theme package (file 'aero.msstyles').

I've been checking dark theme integration in a recent Windows update (Windows11 22H2 10.0.22621).
I notice there is a very useful view for testing SWT widgets, called "SWT Controls". It is located at [1]:

I used this to show Button controls, in SWT.CHECK style. I created a screengrab [2] comparing 3 platforms, Ubuntu, Win10 and Win11, so it's easy to see the difference.

In Win11, the unselected checkbox has a dark background. The selected checkbox has a blue background. I think this shows that Windows support is now in place for Button checkboxes. The same also applies for SWT.RADIO style. SWT.PUSH and SWT.TOGGLE also have a dark BG (same as on Win10).
Unfortunately, SWT.ARROW is the only style that still has a light background.

As this ticket is regarding checkboxes, I think this can now be closed.

I can open a GH Issue for the SWT.ARROW style if people would like?



[1] "SWT Controls"
eclipse.platform.swt\examples\org.eclipse.swt.examples.views\
https://github.com/eclipse-platform/eclipse.platform.swt/blob/master/examples/org.eclipse.swt.examples.views/src/org/eclipse/swt/examples/controls/ControlView.java

[2] SWT Controls - checkboxes - ubuntu 20.04 vs win10 vs win11_22621.PNG
Screengrab shows how Checkbox button controls look across different platforms in dark mode:
ubuntu 20.04 vs win10 vs win11_22621
Ubuntu on LHS and Win11 on RHS.
Comment 7 Lars Vogel CLA 2022-11-22 04:49:06 EST
(In reply to John Moule from comment #6)
> (In reply to Alexandr Miloslavskiy from comment #3)
> > As of Win11 version 22000.527, there is still no support for dark checkbox
> > in native theme package (file 'aero.msstyles').
> 
> I've been checking dark theme integration in a recent Windows update
> (Windows11 22H2 10.0.22621).
> I notice there is a very useful view for testing SWT widgets, called "SWT
> Controls". It is located at [1]:
> 
> I used this to show Button controls, in SWT.CHECK style. I created a
> screengrab [2] comparing 3 platforms, Ubuntu, Win10 and Win11, so it's easy
> to see the difference.
> 
> In Win11, the unselected checkbox has a dark background. The selected
> checkbox has a blue background. I think this shows that Windows support is
> now in place for Button checkboxes. The same also applies for SWT.RADIO
> style. SWT.PUSH and SWT.TOGGLE also have a dark BG (same as on Win10).
> Unfortunately, SWT.ARROW is the only style that still has a light background.
> 
> As this ticket is regarding checkboxes, I think this can now be closed.

Thanks for the check

> I can open a GH Issue for the SWT.ARROW style if people would like?
Yes, please
Comment 8 John Moule CLA 2022-11-25 04:44:16 EST
(In reply to Lars Vogel from comment #7)
> > I can open a GH Issue for the SWT.ARROW style if people would like?
> Yes, please

[Win32][Dark theme] Button with SWT.ARROW style has light background #473
https://github.com/eclipse-platform/eclipse.platform.swt/issues/473