Community
Participate
Working Groups
Created attachment 283933 [details] Screenshot While we were joking in Bug 563473 that some light is nice in these dark times, it actually would be nice, if checkbox buttons are also darker.
Windows 10 doesn't provide any support for Dark Theme checkbox yet. I don't think that we can easily draw it on our own and still keep various small neat details such as mouse hover animation. I think that the problem is very marginal and not worthy of further effort. Hopefully Win10 will just provide the theme at some point.
(In reply to Alexandr Miloslavskiy from comment #1) > Windows 10 doesn't provide any support for Dark Theme checkbox yet. I don't > think that we can easily draw it on our own and still keep various small > neat details such as mouse hover animation. > > I think that the problem is very marginal and not worthy of further effort. > Hopefully Win10 will just provide the theme at some point. Quick check: Does Win10/Win11 support this now ?
As of Win11 version 22000.527, there is still no support for dark checkbox in native theme package (file 'aero.msstyles').
As of Win11 version 22000.527, there is still no support for dark tab in native theme package (file 'aero.msstyles'). 'DarkMode::Tab' style, which was seen in a number of Win10 previews, didn't make it into release version for some reason.
Created attachment 288850 [details] SWT Controls - checkboxes - ubuntu 20.04 vs win10 vs win11_22621.PNG Screengrab shows how Checkbox button controls look across different platforms in dark mode: ubuntu 20.04 vs win10 vs win11_22621 Ubuntu on LHS and Win11 on RHS.
(In reply to Alexandr Miloslavskiy from comment #3) > As of Win11 version 22000.527, there is still no support for dark checkbox > in native theme package (file 'aero.msstyles'). I've been checking dark theme integration in a recent Windows update (Windows11 22H2 10.0.22621). I notice there is a very useful view for testing SWT widgets, called "SWT Controls". It is located at [1]: I used this to show Button controls, in SWT.CHECK style. I created a screengrab [2] comparing 3 platforms, Ubuntu, Win10 and Win11, so it's easy to see the difference. In Win11, the unselected checkbox has a dark background. The selected checkbox has a blue background. I think this shows that Windows support is now in place for Button checkboxes. The same also applies for SWT.RADIO style. SWT.PUSH and SWT.TOGGLE also have a dark BG (same as on Win10). Unfortunately, SWT.ARROW is the only style that still has a light background. As this ticket is regarding checkboxes, I think this can now be closed. I can open a GH Issue for the SWT.ARROW style if people would like? [1] "SWT Controls" eclipse.platform.swt\examples\org.eclipse.swt.examples.views\ https://github.com/eclipse-platform/eclipse.platform.swt/blob/master/examples/org.eclipse.swt.examples.views/src/org/eclipse/swt/examples/controls/ControlView.java [2] SWT Controls - checkboxes - ubuntu 20.04 vs win10 vs win11_22621.PNG Screengrab shows how Checkbox button controls look across different platforms in dark mode: ubuntu 20.04 vs win10 vs win11_22621 Ubuntu on LHS and Win11 on RHS.
(In reply to John Moule from comment #6) > (In reply to Alexandr Miloslavskiy from comment #3) > > As of Win11 version 22000.527, there is still no support for dark checkbox > > in native theme package (file 'aero.msstyles'). > > I've been checking dark theme integration in a recent Windows update > (Windows11 22H2 10.0.22621). > I notice there is a very useful view for testing SWT widgets, called "SWT > Controls". It is located at [1]: > > I used this to show Button controls, in SWT.CHECK style. I created a > screengrab [2] comparing 3 platforms, Ubuntu, Win10 and Win11, so it's easy > to see the difference. > > In Win11, the unselected checkbox has a dark background. The selected > checkbox has a blue background. I think this shows that Windows support is > now in place for Button checkboxes. The same also applies for SWT.RADIO > style. SWT.PUSH and SWT.TOGGLE also have a dark BG (same as on Win10). > Unfortunately, SWT.ARROW is the only style that still has a light background. > > As this ticket is regarding checkboxes, I think this can now be closed. Thanks for the check > I can open a GH Issue for the SWT.ARROW style if people would like? Yes, please
(In reply to Lars Vogel from comment #7) > > I can open a GH Issue for the SWT.ARROW style if people would like? > Yes, please [Win32][Dark theme] Button with SWT.ARROW style has light background #473 https://github.com/eclipse-platform/eclipse.platform.swt/issues/473