Bug 566222 - [Win32][Dark theme] Combos dark light in the dark theme
Summary: [Win32][Dark theme] Combos dark light in the dark theme
Status: VERIFIED FIXED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: SWT (show other bugs)
Version: 4.16   Edit
Hardware: PC Windows 10
: P3 normal (vote)
Target Milestone: 4.17 RC1   Edit
Assignee: Alexandr Miloslavskiy CLA
QA Contact:
URL:
Whiteboard:
Keywords: noteworthy, usability
Depends on:
Blocks: 563540 566401
  Show dependency tree
 
Reported: 2020-08-20 06:34 EDT by Lars Vogel CLA
Modified: 2021-10-13 16:22 EDT (History)
3 users (show)

See Also:
Lars.Vogel: pmc_approved+

Attachments
Screenshot (20.91 KB, image/png)
2020-08-20 06:34 EDT, Lars Vogel CLA 		no flags Details
Screenshot of snippet after patch (27.06 KB, image/png)
2020-08-20 14:49 EDT, Alexandr Miloslavskiy CLA 		no flags Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Lars Vogel CLA 2020-08-20 06:34:07 EDT 
Created attachment 283915 [details]
Screenshot

See screenshot, the combo boxes are light in the dark theme under Windows.

Maybe Windows dark API allows to set this as well?
Comment 1 Lars Vogel CLA 2020-08-20 06:34:29 EDT 
Alexandr, WDYT?
Comment 2 Eclipse Genie CLA 2020-08-20 14:40:09 EDT 
New Gerrit change created: https://git.eclipse.org/r/c/platform/eclipse.platform.swt/+/168026
Comment 3 Alexandr Miloslavskiy CLA 2020-08-20 14:43:34 EDT 
> Alexandr, WDYT?

I think that there is a chance :)
Will you do the testing?
Comment 4 Alexandr Miloslavskiy CLA 2020-08-20 14:49:47 EDT 
Created attachment 283922 [details]
Screenshot of snippet after patch
Comment 5 Lars Vogel CLA 2020-08-21 07:59:11 EDT 
(In reply to Alexandr Miloslavskiy from comment #3)
> > Alexandr, WDYT?
> 
> I think that there is a chance :)
> Will you do the testing?

Tested and it looks great. Please release the change now if you think that this is a low risk change (which it seems to me).

+1 from project lead for RC1.
Comment 7 Alexandr Miloslavskiy CLA 2020-08-21 09:34:22 EDT 
In master now. I think it should be safe enough.
In worst case, it shouldn't affect anything but Dark Theme.
Comment 8 Eclipse Genie CLA 2020-08-21 10:05:33 EDT 
New Gerrit change created: https://git.eclipse.org/r/c/www.eclipse.org/eclipse/news/+/168075
Comment 10 Lars Vogel CLA 2020-08-21 10:06:40 EDT 
(In reply to Alexandr Miloslavskiy from comment #7)
> In master now. I think it should be safe enough.
> In worst case, it shouldn't affect anything but Dark Theme.

Thanks again.
Comment 11 Niraj Modi CLA 2020-08-24 07:07:46 EDT 
Thanks Alexandr/Lars for this enhancement.

We also need N&N entry under SWT section with additional details on how to disable this feature if something goes wrong.
Will add the same from my end shortly.
Comment 12 Eclipse Genie CLA 2020-08-24 07:13:33 EDT 
New Gerrit change created: https://git.eclipse.org/r/c/www.eclipse.org/eclipse/news/+/168131
Comment 14 Niraj Modi CLA 2020-08-24 07:17:58 EDT 
Note:
On Windows 10, all the dark theme tweaks including the dark combo can be disabled using the org.eclipse.swt.internal.win32.disableCustomThemeTweaks Java property.
For Example: add this VM argument in eclipse.ini or on the command line after -vmargs:

-Dorg.eclipse.swt.internal.win32.disableCustomThemeTweaks=true
Comment 15 Niraj Modi CLA 2020-08-26 03:30:32 EDT 
Verified in Build id: I20200825-1800 on Win10.