Bug 565948 - Retire handling for removed EMF model elements like OpaqueMenu
Summary: Retire handling for removed EMF model elements like OpaqueMenu
Status: RESOLVED FIXED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 4.14   Edit
Hardware: PC Linux
: P3 normal (vote)
Target Milestone: 4.17 M3   Edit
Assignee: Lars Vogel CLA
QA Contact:
URL:
Whiteboard:
Keywords: noteworthy
Depends on:
Blocks: 563542
  Show dependency tree
 
Reported: 2020-08-10 07:36 EDT by Lars Vogel CLA
Modified: 2020-08-12 03:35 EDT (History)
3 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Lars Vogel CLA 2020-08-10 07:36:19 EDT 
I think we removed the opaque model elements via Bug 402764.

But it seems that E4XMIResource still has support for them. I suggest we remove that.
Comment 1 Lars Vogel CLA 2020-08-10 07:39:07 EDT 
Rolf and Ed, please have a look at the suggested change.
Comment 2 Eclipse Genie CLA 2020-08-10 07:39:45 EDT 
New Gerrit change created: https://git.eclipse.org/r/c/platform/eclipse.platform.ui/+/167472
Comment 3 Rolf Theunissen CLA 2020-08-10 07:45:28 EDT 
The support in E4XMIResource is there to offer backward compatibility on old workspaces. Similar to the model migration code after the model is loaded. However, this has to be migrated while loading, otherwise the elements will just be lost.

Are you sure you want to remove this compatibility?
Comment 4 Lars Vogel CLA 2020-08-10 07:53:23 EDT 
(In reply to Rolf Theunissen from comment #3)

> Are you sure you want to remove this compatibility?

This would apply for cases in which a workspace which has been created before 2014 and not been opened since when with a newer release is opened by a new release, correct? I think in this case it is fine to remove the migration layer as IMHO the risk is very small and the impact very limited.
Comment 5 Rolf Theunissen CLA 2020-08-11 15:01:57 EDT 
I agree that impact should be minimal.

B.T.W when older workspaces are no longer supported, org.eclipse.ui.internal.ModelMigrationProcessor is also a candidate to be removed.
Comment 7 Lars Vogel CLA 2020-08-12 03:27:34 EDT 
(In reply to Rolf Theunissen from comment #5)
> I agree that impact should be minimal.

Thanks.
 
> B.T.W when older workspaces are no longer supported,
> org.eclipse.ui.internal.ModelMigrationProcessor is also a candidate to be
> removed.

Please open a new bug for this.
Comment 8 Eclipse Genie CLA 2020-08-12 03:33:26 EDT 
New Gerrit change created: https://git.eclipse.org/r/c/www.eclipse.org/eclipse/news/+/167575